Accessible names for icon-only controls + --overlay-popups flag - #1718
Closed
ionite34 wants to merge 1 commit into
Closed
Accessible names for icon-only controls + --overlay-popups flag#1718ionite34 wants to merge 1 commit into
ionite34 wants to merge 1 commit into
Conversation
UI Automation (and screen readers) saw icon-only buttons as their content's ToString - "FluentAvalonia.UI.Controls.SymbolIcon" - making them indistinguishable. Adds AutomationProperties.Name to the package card action buttons, the DocsHelpButton theme, and the NavigationView pane toggle. Adds --overlay-popups to render popups inside the window on Windows (already the default on Linux/macOS), so window captures and the window's automation subtree include open flyouts and dropdowns. Platform options are now composed into one instance per platform before applying: .With<T>() replaces the registered options wholesale, so the per-flag instances were silently dropping earlier settings (X11 OverlayPopups under --disable-gpu-rendering, macOS OverlayPopups under any rendering flag). Co-Authored-By: Lykos (Fable 5) <noreply@lykos.ai>
Member
Author
|
Moved to the dev-branch flow: superseded by ionite34/StabilityMatrix#1348 (with backport-to-main). 🐺 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Accessible names. UI Automation (and screen readers) saw our icon-only buttons as their content's
ToString()—"FluentAvalonia.UI.Controls.SymbolIcon","Avalonia.Controls.StackPanel"— making stop / restart / delete indistinguishable to assistive tech and UI automation. AddsAutomationProperties.Nameto:Resourceslabels where the button already renders oneDocsHelpButtonvia its control theme (mirrors its tooltip)/template/style selector (FluentAvalonia's template gives it no name)The main nav items already expose names correctly (
ListItem "Inference"etc.) — no changes needed there.--overlay-popupsflag. Renders popups (flyouts, dropdowns, menus) inside the window on Windows — already the default on Linux/macOS. With it, window-scoped screen captures and the window's automation subtree include open popups, instead of popups living in separate top-level HWNDs. Opt-in because popups clip to the window bounds in this mode.Platform options composition fix.
.With<T>()replaces the registered options instance wholesale, so the per-flagnew X11PlatformOptions { ... }instances were silently dropping earlier settings — Linux lostOverlayPopupsunder--disable-gpu-rendering(the branch re-statedWmClassbut notOverlayPopups), and macOS lost it under any rendering flag. Options are now composed into one instance per platform and applied once.Tests
AutomationNameTests(headless): asserts the template-selector style actually reaches the pane toggle — a wrong selector is a silent no-op — and thatDocsHelpButtongets its name from the theme. Verified locally: 2/2 pass. Pre-existingMainWindowTestshost crash reproduces identically on cleanmain(unrelated).Why
Groundwork for driving SM via UI automation (agent-driven release screenshots and feature testing): name-based element lookup replaces vision-based coordinate guessing, and
el.bounds()gives exact crop rects for feature close-ups. Same names benefit screen-reader users.🐺 Generated with Lykos (Fable 5)