Repository navigation
feat(importer): load all creature definitions and map populations - #688
Conversation
1ff12c7 to
495838d
Compare
|
Two independent adversarial passes found legacy creature pools being ignored, summoned quest givers losing their relations, and creature zone speech using an unset zone. The repair preserves initial pool selection, keeps the summon dependency relations, and resolves the speaker zone at emission. Both reviewers cleared the combined changes. The final head is Final-head CI is running. Packages #83 remains paired with this change. No production operations were performed. |
495838d to
8b2a8e5
Compare
|
Rebased onto Independent conflict review confirmed the generated feature types and table accessors match the reviewed versions. |
|
Merged after the independent adversarial reviews cleared the repairs and all nine checks passed on The full import profiles now include all 10,384 creature definitions and 66,310 source positions across 34 maps, with map populations scoped to each Shard. Initial pool selection and per-Instance copies have focused durable coverage. Generated Gateway bindings use the CLI and stay ignored. The full local import and reimport passed before the final pool repairs; the repaired pool census and durable tests passed afterward. No Argus deployment or live import was performed. The requested server follow-up was cancelled. |
Bounded imports leave creature definitions and map populations out of the database. They also require separate source inputs for dependent catalogues, such as taxi mount models.
Add
full-world,full-eastern,full-kalimdor, andfull-instances. Every full profile loads the complete creature catalogue. Spawn positions follow map ownership;full-worldretains all 66,310 source positions across 34 maps and all 10,384 definitions. A complete import loads client catalogues and spells before AI, using the same dump for taxi mounts. Gateway bindings follow the CLI generation workflow onmain; generated files are ignored.Preserve population alternatives, legacy pools, fractional chances and event links. Retain summoned quest-giver relations. Resolve creature zones when zone-wide speech is emitted. Give each dungeon and raid Instance its own creature and patrol copies, with respawn and teardown. Complete the EventAI mappings and static dependencies needed by the pinned source, and check imported dungeon hosting at Gateway startup.
What was verified
1ff12c71on a private local SpacetimeDB node. The final pool repair retains all 66,310 positions and accounts for 998 pooled positions in 270 root pools.a31f54ceretained an imported spawn and applied the appended field defaults.Limits and risk
This imports map populations. Seasonal activation, conditional squads, pool rotation after deaths, missing encounter scripts, raid lockouts and battleground rules remain separate work. Conditional positions remain dormant. Interior collision coverage is not complete. Reimport clears creature copies while retaining existing Instance leases; recreate those Instances before resuming play.
The companion Packages PR #83 initializes the new fields in ten playerbot fixtures. The Core and Packages changes must land together.
The schema adds tables, appends defaulted fields and appends enum variants. All serving shards need the matching Module and Gateway. Production capacity, complete terrain extraction and play through a real 1.12.1 client were not tested. Production was not changed.
Made with GPT-6 Astra through the Codex harness in T3 Code.