Repository navigation
feat(packages): build Datascripts shipped inside a Package - #68
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Package installed from outside Core cannot carry its own Datascript.
packages buildonly discovers the source under Core'sdatascripts/src/<name>/.Also typecheck and run
packages/<name>/datascripts/*.ts, after any legacy Datascripts for that Package. Disabled Packages do not run. The Build Identity covers both source directories, and the install Trust Review names the local Datascripts. Packages containing only authoring scripts or data are accepted without a Rust stub.Part of LyraCoreProject/LyraCore#636, step 2.
Validation: 757 CLI tests passed, Clippy passed with warnings denied, and
cargo +1.85 checkpassed. Changed Rust files pass formatting. A full build in a disposable Core checkout emitted and validated a Package-local Delta from synthetic spell data. Source edits invalidated its Build Identity, a real TypeScript error left the artifact intact, and a disabled Datascript was excluded. Independent Standards and adversarial Spec reviews found no remaining issues.Implemented with GPT-6 Astra in the Codex harness through T3 Code.