Repository navigation
feat(bindings): generate Gateway bindings outside the source tree - #76
Merged
Merged
Conversation
Contributor
Author
|
Adversarial review found one cache defect: Rust source directories named All 801 CLI tests and the Rust 1.85 check pass. Core installed this pin, generated the bindings, and passed its Gateway check. Deploy scripts CI also passed. The two pre-existing Clippy findings and untested macOS behavior remain documented above. Ready to merge before Core #689. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gateway bindings are committed generated code. Schema changes require large mechanical diffs and manual preparation.
Add
lyracore bindingsto generate private Rust bindings under.lyracore/generated/gateway/. It checks source and output hashes, prepares a complete replacement, and preserves the previous output if generation fails.bindings --checkgives Cargo a read-only freshness check.dev upprepares bindings before its Gateway build. The Loot Roll upgrade check now reads the prepared schema instead of a committed file marker.Schema extraction and CLI publishing use the checkout Cargo configuration for Rust flags.
Core integration: LyraCoreProject/LyraCore#689. Merge this CLI change first.
What you verified
cargo test -- --test-threads=1: 801 passed, 0 failed.cargo +1.85 check --locked: passed.Installed the pinned CLI through Core's shim and checked command argument handling.
Generated 1,184 Rust files with the real SpacetimeDB tools. The schema reader found all 289 tables, including the Loot Roll receipt.
Checked source edits, linked Packages, missing output, failed replacement, and version mismatch through the process runner and filesystem.
Adversarial review found that source directories named
targetcould escape the freshness check. Removed the exclusions and added a regression that failed before the fix. An independent final review found no remaining material objections.Deploy scripts CI passed at final head
ca736690.What you did NOT verify
No macOS or live Realm verification. Strict CLI Clippy still reports two existing findings in unchanged code:
empty_line_after_doc_commentsinsrc/project.rsandsingle_element_loopinsrc/cmd/import.rs.Model: GPT-6-Astra. Harness: Codex in T3 Code.