Repository navigation
feat(scripts): register named handlers in the welcome examples - #80
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The welcome examples required string event names and numeric IDs in source comments. They now register named functions that take an explicit event parameter. TypeScript uses
PlayerLoginEvent, and Lua uses the sameevents.playerregistration form.Preserve IDs 100300, 100301 and 100302 in
script-ids.json, and rebuild their Script Artifacts and Build Identities with Core f91066df. The all-in-one example tests its compiled artifact through the Package API. CI targets that Core revision and will publishapi-v2, leavingapi-v1available for older Core checkouts. Installation remainspackages addfollowed bypackages apply.Depends on LyraCoreProject/LyraCore#646. The CLI identity support is merged in LyraCoreProject/lyracore-cli#72.
The Package test suite lockfile also records the newer Core test-support dependencies.
Validation: the exact CI formatting, locked Clippy, test and discovery steps passed, plus all seven Python checks. Actual pinned CLI
packages buildandpackages checkpassed; all 1,687 Module tests passed throughcheck-core-tip.shagainst a clean Core checkout. Artifact firewall and API tag publication tests passed. Adversarial review independently verified the generated artifacts, preserved IDs, Build Identity hashes and CI pins. No Package Deltas are committed.Made with GPT-6 Astra and GPT-6.1 Sol through the Codex harness in T3 Code.