Repository navigation
test(dive): add the breath and drowning flow - #10
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LyraCore now sends the Vanilla breath timer and drowning damage packets, but wire-harness had no maintained flow that proved the full dive and surface sequence. A timer or damage packet by itself could not establish that the Character stayed submerged through the advertised window, took the reported damage, and stopped draining after surfacing.
Add a server-neutral
scenario-divemode that sends typed swimming movement, validates the Breath timer, waits through its advertised duration, and requires an own Character Drowning log whose damage matches the observed health drop. It then sends surface movement and requires the matching timer stop before logout. The LyraCore adapter checks the imported liquid cell before changing a clearly named disposable Character, reads the password from stdin, and verifies durable damage and surface position after the run.The Operator run, coordinate selection, head-height calibration, and stock 1.12.1 client acceptance remain pending. Refs LyraCoreProject/LyraCore#142 and LyraCoreProject/LyraCore#12.
Validation:
cargo fmt --checkcargo clippy --all-targets --locked -- -D warningscargo test --locked(39 library, 5 scenario, and 31 benchmark tests)cargo build --release --locked --binsbash tests/lyracore-dive-flow.shbash tests/lyracore-bank-flow.shbash tests/lyracore-suite.shshellcheck --severity=warning adapters/lyracore/test-dive-flow.sh tests/lyracore-dive-flow.shbash -non all adapter scriptsMade by GPT-5.6 Sol with Codex in T3 Code.