Repository navigation
fix(lyracore): encode Operator cleanup actors for durable ownership - #11
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
LyraCore's durable Account ownership work changes the party and Transfer cleanup arguments from a guid to SessionActor. Three adapter calls still used the old argument shape.
Encode the new argument when the matching LyraCore checkout contains Account ownership, and retain bare guids for older checkouts. Operator cleanup sends null ownership and stops before changing party mirrors if the Module refuses it. A fixture World Session must release or expire before this cleanup runs; the adapter never adopts a replacement's token.
Supports LyraCoreProject/LyraCore#61. The supplied checkout must match the published Module, as required by the adapter's source-dependent calls.
All four offline shell checks pass. The new check captures actual command arguments for old and new checkouts, preserves a guid above 2^53 and verifies that a refused LEAVE does not change its mirror. Adapter syntax and diff checks pass. No Realm was accessed.
Model: GPT-6 in the Codex harness.