Repository navigation
test(lyracore): remove realm-wide party cleanup - #13
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The LyraCore wire suite dissolved every party before each scenario. That hid Character-deletion residue and removed unrelated parties from the test Realm.
Scope party setup, assertions, and teardown to each scenario's known Character and party IDs. Add a Headless Client scenario that deletes one member from a three-member party twice, checks both Realm-core and the Shard mirror, and proves a separate party keeps its row, leader, loot settings, and members. Character create and delete probes now wait up to three seconds for the matching Character-list update while retaining the protocol success checks and exact deleted-GUID assertion. Party cleanup also fails closed if it cannot identify or query the authority.
The core behavior test passed on a private two-Shard fixture with LyraCore artifacts from
1d6ec20d797ab1af78e399a2087983e346fc0a61. Both deletion lifecycles passed and preserved the unrelated party. No existing Realm was accessed.The full eight-scenario Playerbots Package run remains pending. A bounded schema audit of 20 local Module artifacts found none with
playerbots_spawn_roleorpkg_playerbots_bot, including the frozen fixture Module. LyraCoreProject/LyraCore#46 should stay open until a compatible Package-enabled Module and Gateway pair is available for that run.Validation:
cargo test --lockedcargo clippy --all-targets --locked -- -D warningscargo fmt --checkparty_deletescenario, two lifecyclesRefs LyraCoreProject/LyraCore#46.
Model: GPT-5.6 Sol, high effort. Harness: Codex T3.