Repository navigation
fix(metrics): refuse invalid counter windows - #14
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Metrics could silently become zero when a series disappeared, and checking two shard selectors together missed counter resets in both. This would make the playerbots load report unreliable.
Share the parser with acceptance callers, preserve exact label identity, and refuse missing, reset or invalid counter windows. The benchmark checks its primary and witness shards separately. Existing substring selectors keep their behavior; acceptance callers use complete label values.
Validation: 81 tests, Clippy with warnings denied, format check, release binaries, and five offline adapter checks passed. The parser also read all 11,890 samples from a saved SpacetimeDB 2.7.1 fixture capture. Independent Standards and Spec review passed. This change does not claim a measured playerbot capacity.
Authored with GPT-6 in Codex; independent agent review used the same Codex workflow.