Repository navigation
feat(playerbots): retain quest ownership evidence - #18
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The imported Playerbots hour could observe bot movement but could not retain the rows that prove quest credit, creature taps, group ownership, and corpse-loot eligibility.
This change binds an exact set of ownership queries and four staged creature entries to the LyraCore Playerbots observer. It retains declared creature entities separately from bot movement, validates every subscribed evidence update, and rejects undeclared entities without counting creature movement as bot progress.
Local checks:
The required remote checks also cover the generic harness on Linux and macOS, release binaries, coverage, offline suite dispatch, and adapter script syntax.
Created by GPT-6 Codex with the Codex coding harness.