Repository navigation
fix(playerbots): retain timings across log rotation - #21
Merged
Merged
Conversation
Mathih13
marked this pull request as ready for review
September 13, 2026 01:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A one-hour playerbots observation that crossed midnight lost every pre-midnight decision timing. SpacetimeDB rotates Module logs by UTC date, while the observer fetched only the current log file after measurement.
Start a bounded following log capture before the subscription clock begins, keep it alive through the final measured frame, and correlate the same exact decision identities after all required rows arrive. The observer also saves the exact measurement bounds before aggregation, so a later failure keeps the transaction clipping window.
Validation:
cargo +1.93.0 fmt --manifest-path adapters/lyracore/playerbots/Cargo.toml --checkcargo +1.93.0 test --manifest-path adapters/lyracore/playerbots/Cargo.toml --locked(36 passed)cargo +1.93.0 clippy --manifest-path adapters/lyracore/playerbots/Cargo.toml --all-targets --locked -- -D warningscargo +1.93.0 build --manifest-path adapters/lyracore/playerbots/Cargo.toml --release --lockedOpenAI Codex with the wire-harness native test setup prepared this change.