Fix EOS confidence suppression at nonzero temperature - #139
Open
primorLee wants to merge 1 commit into
Open
Conversation
|
Thanks for the fix! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
confidence_eos_eot_infcurrently writes the EOS suppression tologits_with_noiseafterx0has already been sampled. At nonzero temperature,logits_with_noiseis a separate tensor, while low-confidence remasking computes probabilities fromlogits. EOS therefore retains its original confidence and can be transferred too early.The zero-temperature path hides the defect because
add_gumbel_noisereturnslogitsitself, so the two names alias the same tensor.Validation
main: expected the ordinary token to transfer first, but EOS is fixed firstpython -m pytest tests/test_generate.py -q(1 passed)git diff --checkFixes #137