Repository navigation
docs(changelog): v1.6.5 readiness follows reachability; add MAG-4641 (MAG-4720) - #615
Merged
Merged
Conversation
…(MAG-4720) The generated v1.6.5 Highlights said the router turns NotReady "when all of its relays fail", which is #581's rule. MAG-4641 (#586) replaced it before the release: a chain turns unhealthy only when no upstream answers, and an error, an error status or a rate limit leaves it as it was. #586 merged into #584's branch and reached main inside #584's squash commit, so the generator gave it no line. Lead the Highlights with the shipped rule and who notices, drop the wrong sentence, add the MAG-4641 line pointing at bb43ae9, and note on the #581 and #584 lines how they relate to it.
idanhen1
approved these changes
Oct 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#Closes MAG-4720
Jira ticket: MAG-4720
Summary
NotReady"when all of its relays fail". That is fix(readiness): turn NotReady when a router's relays all fail (MAG-4617) #581's rule. feat(readiness): readiness follows reachability, three-valued probe (MAG-4641) #586 (MAG-4641) replaced it before the release: a chain turns unhealthy only when no upstream answers, an error, an error status or a rate limit leaves it as it was, and only a result makes it healthy.maininside fix(readiness): give each health-check try its own relay processor (MAG-4639) #584's squash commit (bb43ae9), so the generator listed no line for it.smartrouter_overall_healthstaying1through one, and theverdictfield on theHealth Check Interval Checklog line.feat(readiness)line for MAG-4641 pointing atbb43ae9, and a sub-bullet on each of the fix(readiness): turn NotReady when a router's relays all fail (MAG-4617) #581 and fix(readiness): give each health-check try its own relay processor (MAG-4639) #584 lines. The rest of the lists stay as the mechanical record.Checks
v1.6.5tag:recordProbeResultstores health only forProbeHealthyandProbeUnreachable;probeOthersSoonexists;verdictandhealth result;docs/METRICS.mdhas "When they change".scripts/extract-changelog.sh v1.6.5returns the amended section, and every[#N]and commit reference in it has a link definition.Release page
The v1.6.5 release body has been replaced with
scripts/extract-changelog.sh v1.6.5run on this branch, so it already reads as this PR does. Edits on the release page never sync back toCHANGELOG.md, so this file stays the source. If review changes the text, re-extract after merge.Left unmerged for review.
Screenshots
No UI change.