Repository navigation
Move hardcoded role definitions to config system - #645
Open
cloudburstwan wants to merge 1 commit into
Open
cloudburstwan wants to merge 1 commit into
cloudburstwan wants to merge 1 commit into
Conversation
cloudburstwan
added
bug
Collaborator
Author
|
The test failures I'm not exactly sure what's happening. Seems to be failures within test setup functions rather than tests themselves. Also not sure what's happening with that string. Since tests aren't my forte rn and half the code there is a magical box in my eyes (i've never been good at writing testable code), I'll leave that to @Ixrec to fix as that's their work |
Contributor
|
If we survive the intent application unscathed then yeah I'll figure out what's going on with the tests. For now all code quality issues are on hold until we know how much of Izzy is even allowed to live. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves the hardcoded BanishedRoleId and TartarusRoleId definitions in DiscordHelper to the configuration file system, also updates related tests.
In order to keep some basic organisation, this PR also moves ModRole and ModChannel to a new Moderation configuration category.