Conversation
Adds the raw data behind the requested MTI coverage, unknown-asset, per-asset staleness and TAK-output KPIs, kept definition-free so the thresholds can be decided in the dashboard: - TwinStatusJMX (name=Twins, per twin type and lifecycle): twin counts broken down by MTI state and cumulative MTI-age buckets. Reads the MTI cache through a new side-effect-free MtiStatusRegistry snapshot, so scrapes don't skew the existing lookup hit/miss counters. - TakOutputJMX (name=TakOutput): TAK socket connects, connect failures, disconnects, open connections, last write age, socket and publisher drop counts, and a receipt-to-CoT latency histogram. TakSocketConnection previously swallowed every connection failure without any trace. - MAVLink last message age, for feed-gap detection. NO-ISSUE Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds report-age buckets and joint "reported and MTI-known" counts to TwinStatusJMX, and a PictureRecoveryTracker that times each asset's restoration from valid data back at MAPS to a fresh classified CoT handed to TAK, by failure type (feed loss, restart, MTI status loss) and stage. NO-ISSUE Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Adds an optional tak.additionalServers list to the TwinManager config. Every CoT event, detection and removal the TAK output composes is handed to each additional server as well, so all servers receive the identical MTI-augmented XML. Each server gets its own shared connection, queue and writer thread, so an unreachable server only drops its own events and never delays the primary. Per-server connection health is exported as a TakServer JMX bean (connected, connects, failures, disconnects, drops, writes, last write age, queue size). With the list empty, behaviour is unchanged. NO-ISSUE Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds an optional
tak.additionalServerslist to the TwinManager config, so the CoT that the TAK output composes (including MTI status augmentation) can be delivered to more than one TAK server.TakSocketConnection(connection, bounded queue, writer thread). An unreachable server only fills and drops its own queue; it never delays the primary or the other servers.type=Integration,name=TakServer,server=<host>_<port>,role=primary|additional(connected, connects, connect failures, disconnects, drops, writes, last write age, queue size). The existingTakOutputcounters stay as process-wide totals.TakServerDTOfor the list entries, soTakProtocolDTOdoesn't reference itself in the REST schema.With the list empty (the default), behaviour is unchanged.
Example:
Test plan
AdditionalTakServersTest(real loopback sockets): every server receives the identical CoT event; an unreachable server does not delay delivery to a live one; SSL factory resolved once per server; empty/null listsTakSocketConnectionTest: writes and connect failures are counted per server, and only for that serverTwinManagerConfigTest:additionalServersparsed, invalid entries (no hostname) skipped, default empty, written back bytoConfigurationPropertiesio.mapsmessaging.state.**tests pass (868 run, 0 failures)🤖 Generated with Claude Code