Repository navigation
Wordforms: link analyses to a POS created in the same run (closes #166) - #220
Merged
Merged
Conversation
Preview plans a planned LINK for analyses whose CategoryRA POS the run creates; Move rebinds it. apply_texts now passes the run resolver cache to apply_analyses (it passed None). Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #166
resolve_or_report_categoryreturns a planned LINK for those instead of REPORT_DROPPED. POS not created by the run is still dropped.rebind_planned_link) against the POS the grammar leg created.apply_textswas passingNoneas the resolver cache toapply_analyses; it now passes the run cache.Live evidence (FLEXLIBS_REQUIRE_LIVE=1, GT-Src-166 -> GT-Sandbox-166, restored from Target 2026-07-06 0218.fwbackup; no Target/real project touched):
tests/integration/test_issue166_wordform_planned_pos_link_live.py6 passed. Absent POS created by the run; both analyses on it have CategoryRA = that POS; Preview and Move CategoryRA drops both 0; shared-POS link and morph-bundle links still land. Before the texts.py cache fix the same run showed 2 Move drops (rebind AttributeError on None cache). Unit: 5682 passed.🤖 Generated with Claude Code