Repository navigation
Honour stem/affix picks on the plan path (#117) - #226
Merged
Merged
Conversation
…set vs empty (#117) Co-Authored-By: Claude Sonnet 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Decision
Option 1 (honour the picks), done on the live plan path rather than the unused
categories_affixesstub. The wizard already folds Stem picks intoleaf_item_picks[STEMS], whichstems_enumerate_sourcefilters on. The gap wasSelection.stem_picks/affix_picks, which nothing read, so wizard affix picks and any directSelection(stem_picks=...)still took every entry. Preview also said nothing about picks.Changes
Selection.leaf_picks_for(STEMS/AFFIXES)falls back to a non-emptystem_picks/affix_picks(lower-cased). An explicitleaf_item_picksentry still wins. Empty picks mean transfer all. Closure dependencies are still pulled by the existing closure walk.preview.lexicon_pick_notes, added toRunPlan.category_notes: "no stem picks set -- every stem entry ... is planned" vs "only the N picked stem entries planned (plus the dependencies they need)", for stems and affixes.test_stem_picks_flow_into_compute_plan_owned_childrenis now a passing test, and the stale docstring incategories_affixes.pyis updated.tests/unit/test_117_honour_picks.py(new).test_issue84_lexicon_expansion.pywas adjusted for the extra notes. The unit suite passes (5715 passed).Live evidence (FLEXLIBS_REQUIRE_LIVE=1,
Targetrestored from the Target 2026-07-06 backup, lock "Target-live-flex" held)tests/integration/test_issue117_honour_picks_live.py(3 passed). The source is the privateGT-Src-117, with 2 stems and 2 suffixes authored.stem_picks={A}: Target gained only stem A. Stem B and both affixes were not transferred.affix_picks={a}: Target gained only affix a. Affix b was not transferred.closes #117
🤖 Generated with Claude Code