Repository navigation
feat(referential): format 2, stations with their accesses (v1.1.0) - #3
Merged
Merged
Conversation
Format 2 is format 1 plus, for every station, the entrances and exits of its stop areas (IDFM acces + relations-acces, Licence Ouverte), with the id used by platform positioning. Format 1 is still produced unchanged (minor release). Closed schema stations.format-2.schema.json, CLI format registry, release publishing every format and schema, tests on real extracts.
Owner
Author
Agent reviewChecked: ruff (lint and format), 212 tests, actionlint, a real export of both formats (987 / 15,126 stations, 2,491 accesses for the Paris subset), and the quality of the two new datasets. Worth reading first
Not tested: the release workflow end to end, since it runs at the tag. Not merged, not tagged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Format 2 of the stations referential: format 1 plus, for every station, the accesses (entrances and exits) of its stop areas.
acces(2,523 accesses) andrelations-acces, both under the Licence Ouverte 2.0.id(IDFM:<access id>),name,number(signage number ornull),lat,lon,entry,exit.areas, listed once and sorted by numeric id;[]when none is published.v1.1.0, following the README « Versioning ».Why
The Everyday France app measures the walk to the nearest entrance instead of the hub centre, and shows that entrance's name. Its decision records are D-05 and ADR-0044.
Exits are kept because the IDFM
positionnement-dans-la-ramedataset points to access ids: 3,834 out of 3,834 match this dataset.How it's tested
accesandrelations-accesadded for the fixture hubs. They cover the access fields, the counts per station, deduplication and order, the areas of the selected modes, null numbers, exit-only accesses, source errors, schema closure, and the CLI for both formats.ruffandactionlintclean.To test by hand:
uv sync && uv run export-referential --format 2 --modes METRO,RER,TRAIN,TRAM -o /tmp/stations.jsonVisible in the app: no, not before the app PR that reads format 2.
Limits
--format 1, so a v1.0.0 command keeps its output. The README says to always pass--format.release.ymlhas only been checked withactionlint: it runs at the first tag.After merge
Push the
v1.1.0tag. It freezes format 2 and publishes both formats.🤖 Generated with Claude Code
https://claude.ai/code/session_01L4aZBkZFaLEiu7ax7RdwiD