Repository navigation
fix(settings): theme cards fill the row instead of leaving a strip (core 0.44.3) - #251
Merged
Merged
Conversation
…ore 0.44.3) Owner, 2026-10-21 (relayed from the Flare session): "the themes should compact a bit so like here you should see 4 per row, since there's so close to being enough space". The wall was fixed 196px cards in a wrapping row, so the leftover sat as an empty strip on the right, up to almost a card wide (204px in the e2e window). Now a grid: as many columns as fit at a 172px minimum, 12px gap, each card stretched to fill the row. Card height is unchanged, so the collapsed two-row view is too. Flare uses the same numbers. Tests: the options e2e measures the strip right of the last card; 204px on main (fails), 0px here. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017XYVRPzvhLpPCr75uB6uaA
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 21, 2026
…ore 0.44.3) (#251) Owner, 2026-10-21 (relayed from the Flare session): "the themes should compact a bit so like here you should see 4 per row, since there's so close to being enough space". The wall was fixed 196px cards in a wrapping row, so the leftover sat as an empty strip on the right, up to almost a card wide (204px in the e2e window). Now a grid: as many columns as fit at a 172px minimum, 12px gap, each card stretched to fill the row. Card height is unchanged, so the collapsed two-row view is too. Flare uses the same numbers. Tests: the options e2e measures the strip right of the last card; 204px on main (fails), 0px here. Claude-Session: https://claude.ai/code/session_017XYVRPzvhLpPCr75uB6uaA Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner, 2026-10-21 (relayed from the Flare session): "the themes should compact a bit so like here you should see 4 per row, since there's so close to being enough space".
Cause: the theme wall laid out fixed 196px cards in a wrapping row. Whatever width was left over sat as an empty strip on the right, up to almost one card wide (204px in the e2e window).
Fix: the wall is now a grid. It fits as many columns as it can at a 172px minimum card width with a 12px gap, and stretches the cards to fill the row. The preview's longest line still fits at 172px. Card height is unchanged, so the collapsed two-row view is unchanged too. Flare (PR #12) uses the same numbers.
Core change, so Prism gets it too. Core 0.44.2 -> 0.44.3, app 0.58.2 -> 0.58.3.
Tests:
optionse2e now measures the strip to the right of the last card: 204px on main (fails), 0px here.🤖 Generated with Claude Code
https://claude.ai/code/session_017XYVRPzvhLpPCr75uB6uaA