Repository navigation
fix(agent): a finish or failure on the tab in front while away is held until a tab is clicked (core 0.44.4) - #252
Merged
Conversation
…d until a tab is clicked (core 0.44.4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
…ailed mark too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Owner
Author
|
E2E check: the 4 scenarios that failed in the full run (tabLooks, indicatorStyles, verticalTabs, catchUp) were rerun one at a time on this branch AND on unchanged main (60b6a4a). All 4 fail on main as well (waitForFunction 45 s timeouts; catchUp's orchestrator checks), so they are pre-existing on this machine and not caused by this change. agentHooks (54 checks) and attention pass on the branch. |
…ick of the same tab Owner, 2026-10-23: "have it disappear once I click off the tab". The capture click listener (and HeldMarks.pick) is gone: the release is driven by the tab in front changing, by a click or a key, so a click on the same tab keeps the mark. agentHooks e2e: same-tab click keeps it, leaving clears it (49 checks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017XYVRPzvhLpPCr75uB6uaA
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 23, 2026
…d until a tab is clicked (core 0.44.4) (#252) * fix(agent): a finish or failure on the tab in front while away is held until a tab is clicked (core 0.44.4) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx * fix(agent): a tab's close X does not clear a held mark; e2e holds a Failed mark too Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx * fix(agent): a held mark goes only when you leave the tab, not on a click of the same tab Owner, 2026-10-23: "have it disappear once I click off the tab". The capture click listener (and HeldMarks.pick) is gone: the release is driven by the tab in front changing, by a click or a key, so a click on the same tab keeps the mark. agentHooks e2e: same-tab click keeps it, leaving clears it (49 checks). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_017XYVRPzvhLpPCr75uB6uaA --------- Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the behaviour the owner asked for: when a session finishes (or fails) on the tab in front while the window is unfocused, the Finished/Failed mark and the taskbar badge stay up when you come back, instead of clearing on focus or pointer movement. The mark clears when a tab is clicked, when the tab in front changes with the window focused, when work restarts, when the agent goes, or when the tab closes. Marks raised while looking and Questions are unchanged.
Changes
For the owner to confirm
Gates
🤖 Generated with Claude Code
https://claude.ai/code/session_01DzqPzR6LuAvhiDabNwqzpx
Amended 2026-10-23 (prismterminal-c8)
Owner confirmed: "have it disappear once I click off the tab". A click on the SAME tab now keeps the mark; only leaving the tab (click or key), work restarting, the agent going or the tab closing clears it. The capture click listener and HeldMarks.pick are gone; the release is driven by the tab in front changing. agentHooks e2e: 49 checks, 0 fails, including 'a click on the same tab leaves it up'. Flare is mirroring the same rule.