fix: do not run commands with missing required arguments - #265
Open
kazotaruumc72 wants to merge 1 commit into
Open
fix: do not run commands with missing required arguments#265kazotaruumc72 wants to merge 1 commit into
kazotaruumc72 wants to merge 1 commit into
Conversation
Paper-Dispatch attaches an executor to every required argument builder in SubCommand#addRequiredArgument, so each intermediate node of the chain is executable. A command declaring several required arguments therefore runs when only the first ones are typed, and CommandDispatch#getArgument throws for the arguments that were never parsed: /zmenu create villages java.lang.IllegalArgumentException: No such argument 'inventory-size' exists on this command ZSubCommand removes the executor from every required argument but the last one before the node is built, so Brigadier answers with its usual incomplete command error instead of dispatching a half parsed command. Applies to the six commands declaring more than one required argument: create, players add, players get, players remove, players set and players subtract. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01LXoCyL3N3h2wixGJbm5bj5
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paper-Dispatch attaches an executor to every required argument builder in SubCommand#addRequiredArgument, so each intermediate node of the chain is executable. A command declaring several required arguments therefore runs when only the first ones are typed, and CommandDispatch#getArgument throws for the arguments that were never parsed:
/zmenu create villages
java.lang.IllegalArgumentException: No such argument 'inventory-size'
exists on this command
ZSubCommand removes the executor from every required argument but the last one before the node is built, so Brigadier answers with its usual incomplete command error instead of dispatching a half parsed command.
Applies to the six commands declaring more than one required argument: create, players add, players get, players remove, players set and players subtract.
Claude-Session: https://claude.ai/code/session_01LXoCyL3N3h2wixGJbm5bj5