Skip to content

Add committed ESLint config so CI lint runs non-interactively - #13

Merged
qt314wink merged 1 commit into
fix/frozen-install-webgl-evidencefrom
copilot/407c9bf389be4c8f0b5bdbfb70ab6efbf42df3c5-checks
Sep 8, 2026
Merged

qt314wink merged 1 commit into
fix/frozen-install-webgl-evidencefrom
copilot/407c9bf389be4c8f0b5bdbfb70ab6efbf42df3c5-checks

Conversation

Copilot AI commented Sep 8, 2026

Copy link
Copy Markdown

The failing verification workflow was not hitting a source lint error; it was blocking on Next.js's first-run ESLint setup prompt because the repository had no committed ESLint configuration. In CI, npm run lint exited before the rest of the verification pipeline could proceed.

  • Problem

    • next lint was entering interactive setup in a clean checkout instead of running deterministically.
    • This made the verification workflow fail at the lint step regardless of application code state.
  • Change

    • Commit a minimal project ESLint configuration at the repo root.
    • Align lint tooling with the existing Next.js version by adding the required ESLint packages to devDependencies.
  • Resulting behavior

    • npm run lint now resolves configuration from source control and executes as a normal CI command.
    • The workflow can evaluate lint output directly instead of failing on missing setup state.
  • Config added

    {
      "extends": ["next/core-web-vitals"]
    }

@qt314wink
qt314wink marked this pull request as ready for review September 8, 2026 14:46
Copilot AI lite review requested due to automatic review settings September 8, 2026 14:46
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.

@qt314wink
qt314wink merged commit ebd1a10 into fix/frozen-install-webgl-evidence Sep 8, 2026

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

The added ESLint config and dependencies correctly address the CI interactive prompt issue without introducing risky behavioral changes.

Pull request overview

This PR makes npm run lint deterministic in CI by committing a minimal ESLint configuration and ensuring the required lint dependencies are present, preventing Next.js’s first-run interactive ESLint setup prompt from blocking the verification workflow.

Changes:

  • Add a committed .eslintrc.json extending next/core-web-vitals.
  • Add eslint and eslint-config-next to devDependencies aligned to the pinned Next.js version.
File summaries
File Description
package.json Adds ESLint packages so next lint can run non-interactively in clean CI checkouts.
.eslintrc.json Provides a committed Next.js ESLint config to avoid first-run setup prompts.
Review details
  • Files reviewed: 2/2 changed files
  • Comments generated: 0
  • Review effort level: Lite

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants