Repository navigation
Add committed ESLint config so CI lint runs non-interactively - #13
Merged
qt314wink merged 1 commit intoSep 8, 2026
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
🟢 Approval recommended
The added ESLint config and dependencies correctly address the CI interactive prompt issue without introducing risky behavioral changes.
Pull request overview
This PR makes npm run lint deterministic in CI by committing a minimal ESLint configuration and ensuring the required lint dependencies are present, preventing Next.js’s first-run interactive ESLint setup prompt from blocking the verification workflow.
Changes:
- Add a committed
.eslintrc.jsonextendingnext/core-web-vitals. - Add
eslintandeslint-config-nexttodevDependenciesaligned to the pinned Next.js version.
File summaries
| File | Description |
|---|---|
| package.json | Adds ESLint packages so next lint can run non-interactively in clean CI checkouts. |
| .eslintrc.json | Provides a committed Next.js ESLint config to avoid first-run setup prompts. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The failing verification workflow was not hitting a source lint error; it was blocking on Next.js's first-run ESLint setup prompt because the repository had no committed ESLint configuration. In CI,
npm run lintexited before the rest of the verification pipeline could proceed.Problem
next lintwas entering interactive setup in a clean checkout instead of running deterministically.Change
devDependencies.Resulting behavior
npm run lintnow resolves configuration from source control and executes as a normal CI command.Config added
{ "extends": ["next/core-web-vitals"] }