Skip to content

test(e2e): the real-host doctor test expects 13 findings - #277

Merged
ethanyzhang merged 1 commit into
mainfrom
plugin-e2e-doctor-count
Nov 8, 2026
Merged

ethanyzhang merged 1 commit into
mainfrom
plugin-e2e-doctor-count

Conversation

@ethanyzhang

Copy link
Copy Markdown
Collaborator

Fixes #276.

#269 added the nostr_announce doctor finding (13 in all); the ignored real-host test doctor_and_join_answer_through_the_real_hosts_console still asserted 12 and failed the scheduled e2e (run 42446356365). Count 12 -> 13 and last index 11 -> 12; no product code changes. Applies to v0.1.17 as test-only.

Verification: the run-e2e label runs this test against stock mesh-llm in CI.

…ists (#276)

Signed-off-by: Ethan Zhang <github@yzhang.io>
@ethanyzhang ethanyzhang added the run-e2e Run the two-node e2e on this pull request label Nov 8, 2026
@coderabbitai

coderabbitai Bot commented Nov 8, 2026

Copy link
Copy Markdown

Important

  • Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 72d3408e-8c9b-4659-8f0a-509b62a11da8
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@ethanyzhang

Copy link
Copy Markdown
Collaborator Author

Review record, head f122580 (test-only: doctor finding count 12 -> 13, last index 11 -> 12).

  • Driver: Claude Sonnet 5.5 (read the diff and doctor.rs before peer output).
  • Kimi (kimi-code/kimi-for-coding, session_c773923e-feb1-4486-8c9a-dd137276e145): round 1, CONVERGED. It enumerated the 13 findings in doctor.rs order and found the unit test the_findings_are_evidencebooks_checks_in_its_order already asserts the same order.
  • Codex: unavailable (out of quota until 11-11). One Claude stand-in (claude-opus-5-5, session cd3b801a-927c-4e22-88c6-21526b56b736) took its place: round 1, CONVERGED.
  • Rounds: 1 of 3; calls: 2 of 6. Findings: none; no declines, no disputes.
  • Sherlock2 skipped: no product rule or public text changes.
  • CI on this head: all required checks pass, including "two nodes, stock mesh-llm" (run 42528547856), where doctor_and_join_answer_through_the_real_hosts_console ... ok and the real-host suite is 5 passed; 0 failed.

@ethanyzhang
ethanyzhang merged commit 9b3abd0 into main Nov 8, 2026
13 checks passed
@ethanyzhang
ethanyzhang deleted the plugin-e2e-doctor-count branch November 8, 2026 22:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-e2e Run the two-node e2e on this pull request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

e2e: real-host doctor test still expects 12 findings after nostr_announce (#269)

1 participant