Deprecate resizeWithReserve of Vector and BitSet - #6967
Merged
Merged
Conversation
…t, autoResizeTestSet std::vector::resize already grows the capacity geometrically in libstdc++, libc++ and MSVC STL, so the helpers are replaced with plain resize() + set/[]/test_set everywhere. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…heir call sites Only resizeWithReserve stays deprecated. Up-front sizing (sized constructors, one resize before a loop) is kept where the final size is known. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fedr
changed the title
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Fedr
changed the title
oitel
approved these changes
Sep 29, 2026
Grantim
approved these changes
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Deprecates
Vector::resizeWithReserveandBitSet::resizeWithReserve. Their only purpose was to grow the capacity geometrically, butstd::vector::resizealready does that:max( 2 * capacity, newSize ), since LLVM 3.0;So their callers (
MeshTopology::vertResizeWithReserve/faceResizeWithReserve,PolylineTopology::vertResizeWithReserve,SurfaceManipulationWidget) now useresize(), and so doautoResizeSet/autoResizeAt, which stay unchanged otherwise.The deprecated functions stay in the bindings, since mrbind forwards
[[deprecated]](a PythonDeprecationWarning, a deprecation attribute in C,[Obsolete]in C#).Checked locally (MSVC,
/WX, C4996 enabled): MRMesh, MRVoxels and MRIOExtras build, and all MRViewer and MRTest sources compile.🤖 Generated with Claude Code