mrviewerpy: macOS atexit handler must not touch a viewer it did not launch - #6969
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
oitel
approved these changes
Sep 29, 2026
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes a crash at exit on macOS, introduced by #6864, in applications embedding Python (e.g. MeshInspector's UI tests crashed with SIGSEGV on Intel and SIGABRT on Apple Silicon when closing).
mrviewerpyregistersshutViewerAtExitwithatexit. On macOS it calledpostLaunchDefaultViewer( *gLaunchParams, *gLaunchSetup )whenever the viewer was pre-launched. ButgLaunchParamsandgLaunchSetupare set only bymrviewerpy.launch(). When the viewer was launched by the application itself, they are null, and the embedded interpreter is finalized from a plugin'sshutdown()insideViewer::launchShut(), while the viewer is still pre-launched. So the handler dereferenced null pointers.Now the handler does nothing if the viewer was not launched by this module. Windows and Linux were not affected: there the handler already returns when
gViewerFinishedis not set.🤖 Generated with Claude Code