Minimal restructuring of the fire module to separate fire weather index & INFERNO

[Maggie (maggiehendry)]

PR Summary

Sci/Tech Reviewer: Eleanor Burke (@eleanorgb)
Code Reviewer: Pierre Siddall (@Pierre-siddall)

Code Quality Checklist

(Some checks are automatically carried out via the CI pipeline)

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• If editing rose-meta/jules-shared then have you supplied a linked UM and LFRic Apps PR?

Testing

• I have tested this change locally, using the JULES rose-stem suite
• If shared files have been modified, I have run the UM and LFRic Apps rose stem suites
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (eg. kgo changes)
• I have added tests to cover new functionality as appropriate (eg. system tests, unit tests, etc.)

trac.log

Test Suite Results - jules - jules-test-119-explore-restructuring-the-fire-module/run1

Suite Information

Item	Value
Suite Name	jules-test-119-explore-restructuring-the-fire-module/run1
Suite User	margaret.hendry
Workflow Start	2026-08-24T09:11:23
Groups Run	all

Dependency	Reference	Main Like
jules	maggiehendry/jules@test-119-explore-restructuring-the-fire-module	False
SimSys_Scripts	MetOffice/SimSys_Scripts@2026.07.1	True

Task Information

✅ succeeded tasks - 676

Test Suite Results - um - um-jules-119-explore-restructuring-the-fire-module/run1

Suite Information

Item	Value
Suite Name	um-jules-119-explore-restructuring-the-fire-module/run1
Suite User	margaret.hendry
Workflow Start	2026-08-24T15:54:56
Groups Run	developer', 'jules

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	maggiehendry/jules@d199798	True
moci	MetOffice/moci@2026.07.1	True
mule	MetOffice/mule@2026.07.1	True
shumlib	MetOffice/shumlib@2026.07.1	True
socrates	MetOffice/socrates@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@2026.07.1	True
ukca	MetOffice/ukca@2026.07.1	True
um	maggiehendry/um@53230df	True
um_aux	MetOffice/um_aux@2026.07.1	True
um_meta	MetOffice/um_meta@2026.07.1	True

Approvals

Code Owners

• No UM Code Owners Required

Config Owners

No UM Config Owners Required

Task Information

✅ succeeded tasks - 1084

Test Suite Results - lfric_apps - lfric_apps-jules-119-explore-restructuring-the-fire-module/run1

Suite Information

Item	Value
Suite Name	lfric_apps-jules-119-explore-restructuring-the-fire-module/run1
Suite User	margaret.hendry
Workflow Start	2026-08-24T16:02:40
Groups Run	developer

Dependency	Reference	Main Like
casim	MetOffice/casim@2026.07.1	True
jules	maggiehendry/jules@d199798	True
lfric_apps	maggiehendry/lfric_apps@9151e67	True
lfric_core	MetOffice/lfric_core@2026.07.1	True
moci	MetOffice/moci@2026.07.1	True
SimSys_Scripts	MetOffice/SimSys_Scripts@2026.07.1	True
socrates	MetOffice/socrates@2026.07.1	True
socrates-spectral	MetOffice/socrates-spectral@2026.07.1	True
ukca	MetOffice/ukca@2026.07.1	True

Task Information

✅ succeeded tasks - 1210

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

Approvals

Please request all relevant approvals. See the CodeOwners.txt file for section owners.

Technical

• JULES Code Owner
• OpenMP
• River Routing
• Rose Stem
• Rose Metadata
• Upgrade Macros

Scientific

• Surface
• Hydrology
• Vegetation
• Veg3 RED Demography
• Biogeochemistry
• Biogenic fluxes
• Fire
• Lakes
• Evaluation
• Imogen

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

Please alert the code reviewer via a tag when you have approved the SR

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Maggie (maggiehendry)]

chantelleburton could you possibly have a look at the changes related to the Fire science module please and indicate your approval. Thanks.

[Eleanor Burke (eleanorgb)]

Hi Maggie, I've suggested a change to the doc text, but I think my change will supercede that anyway. Otherwise a small query on what I think is a null change and all looks good. I've approved, I think I can do that with outstanding comments? Eleanor

[Eleanor Burke (eleanorgb)]

that contains switches used to calculate the different fire weather indices available.

[chantelleburton]

Agree with Eleanor's proposed change to the wording

[Eleanor Burke (eleanorgb)]

dont think this is an actual change

[Pierre Siddall (Pierre-siddall)]

Thanks Maggie (@maggiehendry), this looks like a fairly routine refactor to me therefore I'm happy to approve and put this through testing.

[chantelleburton]

chantelleburton could you possibly have a look at the changes related to the Fire science module please and indicate your approval. Thanks.

Thanks for the edits, Maggie. All looks OK to me.