Skip to content

Allow the land fraction to be flipped #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Pierre Siddall (Pierre-siddall) merged 4 commits into from
Aug 27, 2026
Merged

Allow the land fraction to be flipped #144

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
af75f65
Allow the land fraction to be flipped
DanCopsey Jul 22, 2026
a43c1c3
Add my name to CONTRIBUTORS.md
DanCopsey Aug 24, 2026
1c935d8
Merge branch 'main' into fix_river_land_fractions
Pierre-siddall Aug 26, 2026
f730858
Merge branch 'main' into fix_river_land_fractions
Pierre-siddall Aug 26, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CONTRIBUTORS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,4 +6,5 @@
| doucla | Douglas Clark | UKCEH | 2026-07-03 |
| james-bruten-mo | James Bruten | Met Office | 2026-07-09 |
| maggiehendry | Maggie Hendry | Met Office | 2026-08-21 |
| DanCopsey | Dan Copsey | Met Office | 2026-08-24 |
| Pierre-siddall | Pierre Siddall | Met Office | 2026-08-26 |
16 changes: 13 additions & 3 deletions src/initialisation/standalone/ancillaries/init_rivers_process_data_mod.F90
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -286,7 +286,7 @@ SUBROUTINE process_rivers_data( l_use_direction, rivers, rivers_data )
!----------------------------------------------------------------------------
IF ( l_shift_x .OR. l_reverse_y ) THEN
CALL remap_ancil_control( nx_rivers, ny_rivers, rivers_dx, l_shift_x, &
l_reverse_y, rivers )
l_reverse_y, rivers, l_use_land_fraction )
END IF

!----------------------------------------------------------------------------
Expand Down Expand Up @@ -938,7 +938,7 @@ END SUBROUTINE process_rivers_coords
!##############################################################################

SUBROUTINE remap_ancil_control( nx_rivers, ny_rivers, rivers_dx, l_shift_x, &
l_reverse_y, rivers )
l_reverse_y, rivers, l_use_land_fraction )

!------------------------------------------------------------------------------
! Description:
Expand Down Expand Up @@ -967,9 +967,11 @@ SUBROUTINE remap_ancil_control( nx_rivers, ny_rivers, rivers_dx, l_shift_x, &
l_shift_x, &
! Flag indicating that a cyclic shift is applied in the x direction to
! river ancillaries. This can be TRUE only if the coordinate is longitude.
l_reverse_y
l_reverse_y, &
! Flag indicating if the order in the y direction of ancillary fields is
! to be reversed so that the coordinate is monotonically increasing.
l_use_land_fraction
! Flag indicating that we are using land fractions

!------------------------------------------------------------------------------
! Array arguments with INTENT(IN)
Expand Down Expand Up @@ -998,6 +1000,14 @@ SUBROUTINE remap_ancil_control( nx_rivers, ny_rivers, rivers_dx, l_shift_x, &
var(ivar), rivers )
END DO

!------------------------------------------------------------------------------
! Deal with the land fraction field
!------------------------------------------------------------------------------
IF ( l_use_land_fraction ) THEN
CALL remap_ancil( nx_rivers, ny_rivers, rivers_dx, l_shift_x, l_reverse_y, &
'land_fraction_2d', rivers )
END IF

!------------------------------------------------------------------------------
! Having used the river coordinates to remap all the required fields, we now
! change the coordinates themselves. This stage must be done after all other
Expand Down