Remove global scope access of namelist configurations from science component kernels with feigners (tranche 1)

[Ricky Wong (mo-rickywong)]

PR Summary

Sci/Tech Reviewer:
Code Reviewer:

• Initial tranche of kernels where module scope access of configuration variables is removed.
• Helper function added get_mesh_enums to clean up repetitive code on testing mesh for correct enumeration values. Currently using the same as base_mesh so non-updated code doesn't break. Eventually the enumerations will be hardcoded for science components so that there is no dependency on base_mesh_config_mod.
• Places were config_type is passed by argument and mesh_id is used, mesh_id has been switched to the mesh object as part of a larger switch. In addition the order is changed to maintain consistency config, mesh, ..... going forward.
• Additional changes to core/apps tickets as a result of passing config via argument to the correct places so that the configuration variables could be extracted before being passing to the updated kernels in the science component.

Kernels addressed

• components/science/source/kernel/fem/*
  These are updated to pass via argument (and so kernel metadata changes) the namelist variables previous accesed via modules scope. If these have unit-tests, the unit-test file is updated to remove redundant code.

Linked PRs

• linked Update LfricApps to allow for kernel API changes in Core Science components (Tranche 1) lfric_apps#654

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable