Skip to content

fix: fixed the social binding decline not working problem. - #1081

Merged
coodos merged 2 commits into
mainfrom
fix/socialBindings2
Jul 15, 2026
Merged

coodos merged 2 commits into
mainfrom
fix/socialBindings2

Conversation

@Sahil2004

@Sahil2004 Sahil2004 commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Description of change

Fixed the decline button which was not deleting due to incorrect graphql request.
Made it refetch the home screen data to show the real updated data.

Issue Number

Closes #1001
Closes #1082

Type of change

  • Fix (a change which fixes an issue)

How the change has been tested

Manually.

Change checklist

  • I have ensured that the CI Checks pass locally
  • I have removed any unnecessary logic
  • My code is well documented
  • I have signed my commits
  • My code follows the pattern of the application
  • I have self reviewed my code

@Sahil2004 Sahil2004 self-assigned this Jul 10, 2026
@Sahil2004
Sahil2004 requested a review from coodos as a code owner July 10, 2026 08:01
@coderabbitai

coderabbitai Bot commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Warning

Review limit reached

@Sahil2004, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 57 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: 402d894c-60e4-4985-b141-1cccfc3783e5

📥 Commits

Reviewing files that changed from the base of the PR and between 388ccb2 and 4064d62.

📒 Files selected for processing (2)
  • infrastructure/eid-wallet/src/lib/utils/socialBinding.ts
  • infrastructure/eid-wallet/src/routes/(app)/main/components/SocialBindingDrawer.svelte
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch fix/socialBindings2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@plansombl

plansombl Bot commented Jul 12, 2026

Copy link
Copy Markdown

The bug is still present — previously added bindings are appearing as Social Connection Requests when the QR code scanner is opened. Removing from the sign-off board; this needs to be resolved before it can be reviewed again. Please investigate the binding state logic triggered on scanner open and ensure existing bindings are correctly excluded from the Social Connection Request flow.

@coodos
coodos merged commit a8cdd5e into main Jul 15, 2026
3 checks passed
@coodos
coodos deleted the fix/socialBindings2 branch July 15, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

2 participants