Skip to content

fix(eid-wallet): wait for cold-start deep links before authentication - #1135

Open
Sahil2004 wants to merge 1 commit into
mainfrom
fix/eid-wallet-cold-start-deeplink-race
Open

Sahil2004 wants to merge 1 commit into
mainfrom
fix/eid-wallet-cold-start-deeplink-race

Conversation

@Sahil2004

Copy link
Copy Markdown
Contributor

Description of change

Prevent the splash biometric flow from routing to /main before the initial Tauri deep link has been discovered. The root layout now exposes an initialization promise, resolves it after deep-link setup finishes (including failure), and the splash awaits it before checking pendingDeepLink.

This fixes the timing-dependent regression related to #1048 / #1078: completing biometric authentication quickly could skip the consent screen, while completing it slowly worked.

Type of change

  • Fix

How the change has been tested

  • pnpm check in infrastructure/eid-wallet (0 errors; 5 pre-existing Svelte warnings)
  • git diff --check

Change checklist

  • Cold-start deep-link discovery completes before splash authentication chooses a route
  • Deep-link initialization failures do not leave the splash waiting indefinitely
  • Unrelated generated-project and local Firebase files are excluded

@Sahil2004
Sahil2004 requested a review from coodos as a code owner September 14, 2026 15:07
@coderabbitai

coderabbitai Bot commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: 88c40da2-be10-4428-b1bb-cad661f2eb69


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant