Repository navigation
Bound artifact finalization under one owned cleanup deadline - #254
Merged
Merged
Conversation
Co-authored-by: GPT-6 <noreply@openai.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runtime finalization now shares one absolute cleanup deadline across private trajectories, results, and replay uploads. Inference cancellation remains irreversible; the separate artifact API completes owned PUT/POST handles before returning, including after SIGTERM.
The new
artifact_runtimemodule keeps native transport imports out of simulation and WebAssembly codecs. Private local trajectories retain exclusive creation and mode 0600. Existing HTTP reader/writer pools now close and join their workers.Validation: Nim 2.2.4 on Zephyrus, bounded 2 CPUs/2 GiB/Nice 19. Eight actual artifact cases passed: PUT, POST, interrupted inference followed by checkpoint, shared-budget expiry, writer success, HTTP 503 rejection, SIGTERM during upload, and sixteen retained reader/writer requests with zero remaining workers. Exclusive interrupted private checkpoint passed. All eight native HTTP deadline/partial-byte/signal regressions and fourteen private trajectory tests passed.
Exact commands:
nim c -d:release --threads:on --mm:orc --parallelBuild:2 tests/support/artifact_http_probe.nim;python3 tests/test_artifact_http.py <probe>; existing native HTTP probe and trajectory suite. Proofs:/tmp/coworld-bitworld-artifact-httponrelh@zephyrus. No production uploads or deployment changes.