Repository navigation
Restart listeners when only their authentication secret changes - #8
Merged
Merged
Conversation
Reapply decides whether a recompile changed anything by comparing instance fingerprints, but it only compared outbounds. Rotating a secret used only by a listener's users reported no change, and the listener kept accepting the old password. Compare listener fingerprints too. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reapplyrecompiles the active documents after a secret changes and commits only if an instance changed. The check compared outbound fingerprints only, so rotating a secret used solely by a listener's authentication users reported no change and the listener kept accepting the old password.Change
sameInstancesnow also compares each listener's ID and fingerprint. The listener fingerprint already includes its resolved users, so a rotated password makes the commit go through and the engine restarts that listener.Testing
TestReapplyRotatesListenerOnlySecret: a SOCKS5 listener whose password is a secret; after rotating the secret and callingReapply, the new password passes traffic and the old one is rejected. It failed before the change (NoChange).make test,make raceoninternal/config/service/..., andGOOS={darwin,linux,windows,android} GOARCH=arm64 make vetpass.🤖 Generated with Claude Code