Skip to content

Restart listeners when only their authentication secret changes - #8

Merged
MimoProxy merged 1 commit into
mainfrom
kernel/listener-secret-rotation
Nov 21, 2026
Merged

MimoProxy merged 1 commit into
mainfrom
kernel/listener-secret-rotation

Conversation

@MimoProxy

Copy link
Copy Markdown
Owner

Reapply recompiles the active documents after a secret changes and commits only if an instance changed. The check compared outbound fingerprints only, so rotating a secret used solely by a listener's authentication users reported no change and the listener kept accepting the old password.

Change

sameInstances now also compares each listener's ID and fingerprint. The listener fingerprint already includes its resolved users, so a rotated password makes the commit go through and the engine restarts that listener.

Testing

  • New TestReapplyRotatesListenerOnlySecret: a SOCKS5 listener whose password is a secret; after rotating the secret and calling Reapply, the new password passes traffic and the old one is rejected. It failed before the change (NoChange).
  • make test, make race on internal/config/service/..., and GOOS={darwin,linux,windows,android} GOARCH=arm64 make vet pass.

🤖 Generated with Claude Code

Reapply decides whether a recompile changed anything by comparing
instance fingerprints, but it only compared outbounds. Rotating a secret
used only by a listener's users reported no change, and the listener
kept accepting the old password. Compare listener fingerprints too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@MimoProxy
MimoProxy enabled auto-merge (rebase) November 21, 2026 15:30
@MimoProxy
MimoProxy merged commit 3e496b4 into main Nov 21, 2026
17 checks passed
@MimoProxy
MimoProxy deleted the kernel/listener-secret-rotation branch November 21, 2026 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant