Repository navigation
refactor: split the drift check into rule classes run by a validator - #109
Merged
Merged
Conversation
Each check of npm run drift is now a DriftRule subclass under scripts/drift/rules/. DriftValidator runs all rules against a DriftContext that computes the snapshot, lock comparison and variant pairs once. Every message is prefixed with its rule's name. check-drift.mjs stays the CLI entry point.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The drift check lived in one script where several unnamed checks were bundled into a few large functions, so a failure did not say which rule raised it and single rules were hard to test or extend.
What
npm run driftis now a class extendingDriftRuleunderscripts/drift/rules/(12 rules: lock, classification, manifest hygiene, variant parity).DriftValidatorknows all rules and runs them against aDriftContext, which computes the snapshot, the lock comparison and the Kotlin/Java variant pairs once.DriftSnapshot,VariantPair,EngineNormalizer,ManifestScope.[LockedCopiesStayIdentical] LICENSE drifted in …; the message text itself is unchanged.scripts/check-drift.mjsstays the CLI entry point, sonpm run drift,npm run drift:updateand the pre-commit hook are unchanged.Verification
npm test: 48 of 48 pass; the existing assertions only gained the rule prefix.npm run drift: 12 examples in step, 4473 locked copies.npm run drift:updateregenerates an identicaldrift.lock.yml.LICENSEreports the drift as before.