Make the quick-approve button PR-state aware (v1.2.0)

[MishaKav]

What

The floating ✅ Quick approve button in github-pr-approve-helper.user.js (v1.1.0 → v1.2.0) no longer shows uniformly on every linear-b PR:

• Merged or closed PR → no widget at all (nothing sensible to approve)
• Already approved by me → a passive, dismissible "👍 Already approved" pill instead of the button — no more accidental double approves
• Open, not yet reviewed → the button, unchanged

After a quick-approve, the 🎉 Approved feedback hands over to the indicator within the session.

How — state detection without tokens or storage

Layered, cheapest first, cached per PR, always failing open (never hides the button on a PR that isn't confirmed approved/merged):

1. In-session memory of approvals made through the button (no localStorage — deliberately dropped)
2. Live page signals, grounded in real markup inspected on an actual PR page:
   • merged/closed via the header badge [data-component="StateLabel"][data-status="pullMerged|pullClosed"], with legacy .State class/title/text fallbacks
   • approved-by-me via my reviewers-sidebar entry <a id="review-status-<login>"> containing the octicon-check verdict icon (username from meta[name="user-login"])
   • fallback: tooltips/timeline entries whose own short text starts with <login> approved these changes — anchored per element, so another reviewer's approval can never cross-match (fixes a false "already approved" seen on a PR that requested my review while someone else had approved)
3. One cached same-origin fetch of the conversation page when on the Files changed tab (which lacks the sidebar/timeline), parsed with the same detector

Every detection logs one pr state: <state> (<source>, via <signal>) console line for one-paste diagnosis of any future markup drift.

Testing

Playwright harness (real userscript in a Chromium isolated world, React replica + fake backend): 40/40 checks — all 29 pre-existing quick-approve/dialog behaviors, plus: merged/approved via live markup, both fetch-layer states, indicator dismissal, success-to-indicator handover, and a regression test reproducing the review-requested false positive. Also verified manually on real linear-b PRs.

🤖 Generated with Claude Code

https://claude.ai/code/session_01JL2YxajmCPuDRWyejSpCJM

---

Generated by Claude Code

[Copilot]

🟡 Changes recommended

The new “Already approved” indicator is implemented as a clickable <div> (keyboard accessibility issue) and there’s an inaccurate comment about fetch tracking that should be corrected.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Pull request overview

This PR updates github-pr-approve-helper.user.js to make the floating “✅ Quick approve” UI PR-state aware, hiding it on merged/closed PRs and replacing it with a dismissible “👍 Already approved” indicator when the current user has already approved.

Changes:

• Adds PR-state detection (merged/closed/approved/open) using live DOM signals plus a cached conversation-page fetch fallback.
• Introduces an “Already approved” indicator and hands over to it after a successful quick-approve.
• Updates versioning to v1.2.0 and adjusts PR URL building helpers.

File summaries

File	Description
github-pr-approve-helper.user.js	Adds PR-state detection + new “Already approved” indicator behavior for the quick-approve widget

Review details

• Files reviewed: 1/1 changed files
• Comments generated: 2
• Review effort level: Lite

---

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

[Copilot]

🟡 Changes recommended

Caching the 'open' state can make the UI state sticky and prevent later detection of approvals/merges within the same session, enabling accidental double-approves.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review details

Suppressed comments (1)

github-pr-approve-helper.user.js:681

• The conversation-page fetch path caches 'open' (including in the .catch) the same way as the live-path does. This can freeze the display state as "open" for the rest of the session after a transient fetch/parse miss, preventing later live detection of an approval/merge and allowing accidental double-approves.

          const state = detection?.state ?? 'open';
          prStateCache.set(key, state);
          console.log(
            `[GitHub PR Approve Helper] pr state: ${state} (conversation page${
              detection ? `, via ${detection.via}` : ''
            })`,
          );
          scheduleScan();
        })
        .catch(() => prStateCache.set(key, 'open'));

• Files reviewed: 1/1 changed files
• Comments generated: 2
• Review effort level: Lite