Fix Collection Case Action Sounds Playing for Other Players - Fix #143#147
Open
Superkat32 wants to merge 2 commits into
Open
Fix Collection Case Action Sounds Playing for Other Players - Fix #143#147Superkat32 wants to merge 2 commits into
Superkat32 wants to merge 2 commits into
Conversation
…nt Collection Case scrolling when there is nothing to scroll through
Awakened-Redstone
requested changes
Jul 15, 2026
Comment on lines
-89
to
-90
| super.appendHoverText(stack, context, displayComponent, textConsumer, type); | ||
|
|
Member
There was a problem hiding this comment.
I think it's better to keep the super even if it is empty by default. It is possible a mod injects into the super method, so unless we don't want anything from that, it's better to just keep it.
Member
There was a problem hiding this comment.
I've actually had a case where mods and I think minecraft itself not calling super on item use made things significantly harder >.<
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simple fix for #143, where sounds from the Collection Case (adding/removing items, scrolling) would be played for nearby players. Nothing is needed for making scrolling on the client, as Collection Case actions are already client-sided (I initially assumed they weren't when Tomate and I discovered this bug, which is why it was mentioned)
I also tried to figure out #132, but it's a much more convoluted problem than you'd think. My attempted solution was "if collectable is selected and (collected or player is in creative)", bolden.
However, The
type.isCreative()method in the tooltip method is not checking whether the player is in creative mode, but rather if the item is in the creative mode search screen. I don't think there is anywhere to access the information we need without mixins or a separate class to call the client Minecraft instance, so I left it.With that, I initially fixed a bug where players can scroll through the Collection Case even if there's nothing to scroll through, but because of #132, I've opted to un-fix that for now.