fix: pin Node 22 for Cloudflare Pages - #17
Merged
Conversation
The Pages v2 image still defaults to Node 18. rsbuild/rsdoctor refuse to load there. .nvmrc and .node-version tell Pages to use 22; rsdoctor only loads when RSDOCTOR=true.
npm run build is now NODE_ENV=production and never loads rsdoctor. Analyze lives in rsbuild.analyze.ts; rstest stays a local/CI command.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pages v2 defaults to Node 18.17.1. rsbuild then dies with Expected Node.js >= 20. Pin 22 via .nvmrc/.node-version and stop importing rsdoctor on every build.