Repository navigation
feat: visual polish — dark mode, toast notifications, loading skeletons - #18
Merged
Merged
Conversation
Adds the three items closing out the "complete product" roadmap's final phase: - Dark mode: Tailwind's class-based dark mode (tailwind.config.js), ThemeContext (persists to localStorage, falls back to the OS preference, degrades gracefully — same try/catch pattern as tokenStore.ts — if storage is blocked), and a ThemeToggle in the top bar. Every page and component gets dark: variants; nothing was left light-only. - Toast notifications: a dependency-free ToastContext/ToastContainer (no library pulled in for a handful of confirmation messages, same call this codebase already made for icons.tsx) wired into checkout completion, staff invites, product create/delete, and conflict resolution — success and failure both surface a toast, stacked, auto-dismissing after 4s or on click. - Loading skeletons: Skeleton.tsx's layout-shaped placeholders replace spinner/text loading states on CounterPage's item grid, DashboardPage's summary tiles, and AuditLogView's history list, so the page doesn't visually jump once real content arrives. Tests: 9 new (ThemeContext, ToastContext/ToastContainer), 1 new App.test.tsx case for the theme toggle; HeroPage.test.tsx and StaffPage.test.tsx updated to wrap the providers their pages now depend on. Full suite verified green (66/66 web), typecheck and lint clean, production build succeeds. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds the three items closing out the "complete product" roadmap's final phase:
Dark mode: Tailwind's class-based dark mode (tailwind.config.js), ThemeContext (persists to localStorage, falls back to the OS preference, degrades gracefully — same try/catch pattern as tokenStore.ts — if storage is blocked), and a ThemeToggle in the top bar. Every page and component gets dark: variants; nothing was left light-only.
Toast notifications: a dependency-free ToastContext/ToastContainer (no library pulled in for a handful of confirmation messages, same call this codebase already made for icons.tsx) wired into checkout completion, staff invites, product create/delete, and conflict resolution — success and failure both surface a toast, stacked, auto-dismissing after 4s or on click.
Loading skeletons: Skeleton.tsx's layout-shaped placeholders replace spinner/text loading states on CounterPage's item grid, DashboardPage's summary tiles, and AuditLogView's history list, so the page doesn't visually jump once real content arrives.
Tests: 9 new (ThemeContext, ToastContext/ToastContainer), 1 new App.test.tsx case for the theme toggle; HeroPage.test.tsx and StaffPage.test.tsx updated to wrap the providers their pages now depend on. Full suite verified green (66/66 web), typecheck and lint clean, production build succeeds.