Repository navigation
fix: clear localStorage between ThemeContext tests to stop cross-test… - #19
Merged
Merged
Conversation
… leak CI's Linux jsdom has a working localStorage (unlike this project's local dev environment), so the "defaults to light" test's persisted value was leaking into the "defaults to dark" test and masking the matchMedia stub, failing CI while passing locally. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… leak
CI's Linux jsdom has a working localStorage (unlike this project's local dev environment), so the "defaults to light" test's persisted value was leaking into the "defaults to dark" test and masking the matchMedia stub, failing CI while passing locally.