-
Notifications
You must be signed in to change notification settings - Fork 3
MoonLive: scripted effects, modifiers and layouts, compiled on the device #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
9afeec1
Rename the Layers container to Effects
ewowi f99ee5e
Give MoonLive arithmetic and print(); add a scripted modifier
ewowi 6b56dce
Fix subtraction on Xtensa and arm64: -1 was materialised as 65535
ewowi aa2e75f
Add MoonLiveLayout: place lights from a script, with for loops
ewowi c28015b
Fix two register miscompiles; nested loops compile on Xtensa
ewowi 32026eb
Size MoonLive to the script; fix three device register bugs
ewowi 32ed3f6
Revert "Size MoonLive to the script; fix three device register bugs"
ewowi 4806046
Fix two heap overruns that crashed a layout resize
ewowi 9e5169a
Reserve the names the engine supplies to a live script
ewowi 746c4e1
Compile with CI's toolchain, and correct what the docs claimed
ewowi 41eb2c0
Reject the for-loop typos that used to compile clean
ewowi File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Keep the README pipeline terminology consistent.
Line 23 now uses
Effects, but Line 106 still describeslayouts → layers with effects + modifiers → drivers. The README presents two names for the same top-level stage. Update Line 106 to useEffectsand distinguish itsLayerchildren.🤖 Prompt for AI Agents
Source: Coding guidelines