Repository navigation
fix: stop treating a closed store as an invalid license - #40
Merged
Merged
Conversation
store_closed_error derived from license_invalid_error, so a store that had closed its Moonbase account locked the license, and apps that delete the stored license on an invalid one dropped a license the buyer still owns. It now derives from moonbase_error and reads like being offline: within the grace period validate_token_online keeps the license, and since the answer is not signed it relaxes nothing. When a closed store answers a validation with an offline license, the SDK stores it and never asks again, as for any offline license. The JUCE controller no longer locks on it, and deactivating on a closed store keeps the license and says why, since the device could not be activated again. Code that caught license_invalid_error to handle a closed store must catch store_closed_error instead.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 9, 2026
## [4.9.1](v4.9.0...v4.9.1) (2026-10-09) ### Bug Fixes * stop treating a closed store as an invalid license ([#40](#40)) ([f9d8e09](f9d8e09))
|
🎉 This PR is included in version 4.9.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
store_closed_errorderived fromlicense_invalid_error, so a store that had closed its Moonbase account locked the license, and apps that delete the stored license on an invalid one dropped a license the buyer still owns. It now derives frommoonbase_errorand reads like being offline:validate_token_onlinekeeps the license within the grace period, the unsigned answer relaxes nothing, and an offline license returned by a closed store's validation is stored and never re-validated, as for any offline license. The JUCE controller no longer locks on it, and deactivating on a closed store keeps the license and says why, since the device could not be activated again. Note for upgraders: code that caughtlicense_invalid_errorto handle a closed store must catchstore_closed_errorinstead; new core and JUCE tests cover these paths, and the full suite passes on macOS with JUCE 8.0.4.