Repository navigation
feat(juce): show endless trials without a countdown - #42
Merged
Merged
Conversation
Moonbase products can now offer trials that never expire, whose tokens carry no exp. The core SDK already accepted them, but the JUCE module's trial screen read the missing expiry as zero days: "TRIAL · 0 DAYS LEFT", "0 of 14 days remaining" and an empty progress bar on a trial that was still running. ActivationController gains trialIsEndless(). The trial screen then shows a plain "TRIAL" badge, says the trial has no time limit and drops the bar. The ended screen leaves out the "N-day" length for a trial that had none, and says the trial "has ended" when there is no end date to name, instead of a sentence without a verb.
|
The latest updates on your projects. Learn more about Argos notifications ↗︎
|
std::filesystem::rename on Windows keeps the renamed license open with DELETE access for a moment after it lands, and std::ifstream does not share delete access, so a reader opening the license in that window got a sharing violation and load_local_license threw storage_error. The torn-write test caught this on the Windows runner. Reading now goes through the same short retry the rename already used on Windows, pulled out into one helper. Elsewhere it still tries once.
github-actions Bot
pushed a commit
that referenced
this pull request
Oct 13, 2026
# [4.10.0](v4.9.2...v4.10.0) (2026-10-13) ### Features * **juce:** show endless trials without a countdown ([#42](#42)) ([a664cda](a664cda))
|
🎉 This PR is included in version 4.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moonbase products can now offer trials that never expire, and such a trial's token carries no
exp. The core SDK already accepted that (expires_atis empty and nothing expires it), but the JUCE module's trial screen read the missing expiry as zero days: "TRIAL · 0 DAYS LEFT", "0 of 14 days remaining" and an empty progress bar on a trial that was still running.ActivationController::trialIsEndless()says when the loaded trial has no end date. The trial screen then shows a plain "TRIAL" badge, says "Your trial has no time limit", and drops the progress bar and the space it took. The ended screen (a vendor can still end an endless trial, which the API reports as expired) leaves out the "N-day" length for a trial that had none, and says the trial "has ended" when there is no end date to name; before, that case read "Your trial of Solstice. Unlock the full version…".trialLengthDaysand the JUCE module guide note that an endless trial ignores it.Two controller tests cover an endless trial staying unlocked through a license-watch tick with no countdown, and one the vendor ends going to the Expired screen. Two new snapshots,
06d-trial-endlessand06e-trial-endless-ended, will show up as new in Argos. The JUCE suite passes on macOS (107 tests) and the module headers are in sync.This also fixes the Windows CI failure on
maininfile_license_store readers never catch the license half-written. On Windows,std::filesystem::renamekeeps the renamed license open with delete access for a moment after it lands, andstd::ifstreamdoesn't share delete access. So a reader that opened the license right then got a sharing violation, andload_local_licensethrewstorage_error. Opening the license now uses the same short Windows retry the rename already used, pulled out into one helper; other platforms still try once.