Repository navigation
perf: Buffer zip output writes and write decoded res files in parallel - #3
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds buffering to FileChannelOutputStream.
Patching YouTube reduces file write time from ~7 seconds to ~1.2 seconds.
The stream now buffers writes, and ZipFileOutput flushes before using the channel directly.
Decoded res files are written by 2 background threads. Decoding is still done on the calling thread as the table is not thread safe.
Tried with 4 threads and increasing MAX_PENDING_WRITE_BYTES, but performance did not improve over 2 threads and 16MB pending write buffer.