Repository navigation
Conversation
The datamixer API does not resolve plain redirect short links such as maps.app.goo.gl, so getDynamicLink returned null and Google Maps dropped shared routes. Fall back to reading the redirect target for these hosts. Fixes #329 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011yUEQwgLML4GnnJoy2retw
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #329
DynamicLinksService.getDynamicLink()returnednullfor Google Maps short links (https://maps.app.goo.gl/...), because the datamixer API does not resolve them. Google Maps then drops the link without a message, for example routes sent with "Send to car".Changes:
DynamicLinkUtils.resolveRedirectShortLink(): requests the short link without following redirects and returns thehttpsLocationtarget. It follows at most 5 short-link hops, with a 10 s timeout.getDynamicLinkuses this fallback only when the datamixer response has nointentDataand the link is anhttpslink ongoo.gl/maps.app.goo.gl. All other links behave as before.Builds (Debug and Release, including lint) pass. Not tested on a device yet.