Repository navigation
chore: Merge branch dev to main - #340
Draft
github-actions[bot] wants to merge 9 commits into
Draft
github-actions[bot] wants to merge 9 commits into
github-actions[bot] wants to merge 9 commits into
Conversation
…N_OVERLAY) The Play Games sign-in flow showed a 'connecting' popup via WindowManager.addView with TYPE_APPLICATION_OVERLAY / TYPE_PHONE and no SYSTEM_ALERT_WINDOW permission check. SYSTEM_ALERT_WINDOW is deliberately undeclared (see #307), so addView can never succeed on stock ROMs: the popup path is dead code carrying a risky overlay pattern, and its TYPE_APPLICATION_OVERLAY / canDrawOverlays strings remain visible to installer scanners. Removing it completes the overlay removal started in #307 and reduces those signals. No claim is made that this changes any vendor install verdict — that can only be decided by installing the rebuilt APK on a phone. - AccountPromptManager: drop the overlay WindowManager path (layout params, addView/removeView); view inflation and the prepare/showPlayer animation logic are unchanged. - GamesService: drop the showConnectingPopup caller; Play Games sign-in itself is unchanged. - SelfCheckFragment: drop the dead if (false) block referencing SYSTEM_ALERT_WINDOW / ACTION_MANAGE_OVERLAY_PERMISSION. Firebase phone auth via the foreground ReCaptchaActivity is untouched.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request will Merge branch
devtomain.Before merging this PR