Repository navigation
fix: native workflow timestamps, renderer ownership and acceptance evidence - #30
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Saved-project cards displayed Invalid Date because the backend returns Unix seconds, and native renderer startup could panic when graph/timeline runners recreated winit's event loop. This change reads the database modification time, formats it safely, disables graph-camera tonemapping that requires missing LUT assets, and rejects second event-loop reservations with an actionable restart message. A still-running hidden graph owner can be shown again; unified multi-window rendering remains deferred.
Includes a guarded, authored-fiction demo and seven genuine native application captures with provenance and honest captions in the acceptance report. Verified native project open, screenplay/Bible edits and save/reopen, cancelled screenplay edits, timeline title changes, graph hide/show, separate timeline startup/close, and visible renderer rejection. Native renderer views remain minimal; the main editor screenshots carry the readable labels.
Validation: repository pre-commit and full pre-push checks passed; frontend 603 tests, desktop 95 tests, native graph 61 tests (one existing display test ignored), persistence six tests, production UI build, workspace clippy with warnings denied, and decision traceability passed. Exact-head CI run 97 completed successfully on 0f3481c: Linux and Windows each passed 966 Rust tests, workspace clippy/all-feature no-download checks, and formatting; Frontend passed 603 tests plus lint/format/typecheck and authoring fixtures; Decision Traceability passed. Both Rust platforms retain two existing ignored native-display tests.
No real model inference ran: no weights or unpublished Pumas fixes are available here. Producer changes, reference indexing/retrieval and model lifecycle acceptance remain coordinated with separate PR #29, which is unchanged at b09f9c2. This branch retains main's Pumas pin. No private data/raw logs, model weights, deployment, or merge.