Repository navigation
Integrate exact authoring custody and guarded timeline operations - #31
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bible saves trimmed authored whitespace, unavailable saved blocks hid retained drafts, and main lacked clip arc assignment and atomic sibling reorder. This integrates the four accepted changes once through merge ed6b6fe, retaining source histories and main's native UI/architecture. PR32 adds saved-block types as a disjoint stacked review.
Exact head: f729aa0; tree da7d4563647b48a4a00f681d98ad626250b5bbf7. The independently reviewed frontend dependency repair from PR29be03 is selectively retained (manifests/lockfile, audit/build CI gates, historical audit report). Main's exact Pumas a94fd920 contract remains; PR29's inference/model source and branch are unchanged.
Local checks passed 127 core and 614 server all-target tests, strict all-feature core/server Clippy, 111 files/636 UI tests, lint/format/typecheck (0 errors/warnings), static build, exact-lock audit (zero moderate/high/critical; three existing low cookie rows), ONNX no-download metadata and decision traceability. Independent GPT-6.1 Sol High review approves this exact final head/tree with no P1/P2.
Initial CI102 passed Linux, frontend and traceability but failed the existing Windows injected renderer panic test: its 200ms completion receive timed out before hook/unwind scheduling finished. Forward commit f729 changes only that test to a bounded five-second wait, preserving assertions and production behavior, plus evidence notes. Fresh full CI104 passed all four jobs on this exact head: https://github.com/MrScripty/Eidetic/actions/runs/38653052907 . Linux and Windows each passed 986 Rust tests (two existing ignored); frontend passed 636 tests plus audit/lint/format/typecheck/static build; decision traceability passed. The tested merge8cbd96ee tree matches the independently reviewed da7d4563 head tree. The repaired panic test passes on both platforms. The failed historical run remains recorded.
The enabled local native pre-push attempt fails at absent glib/GTK/WebKit development libraries. Publication used only the existing authorized unavailable-test exclusion with hosted full workspace gates. Current Chromium widget smoke aborted before page execution at its misconfigured enabled SUID sandbox; no sandbox was disabled. Current compiled-client/SSR and actual public-service/SQLite checks are evidence; current browser/native interaction remains unqualified. Historical reports and controlled fixtures do not qualify current trained models. PR29's real chat/embedding acceptance gate remains intact.
Parent owns actual merges after reviewing exact CI and these limits. PR31 first; retarget PR32 to fresh main, verify unchanged merge tree and required base-sensitive checks before merging. Useful source branches and PR29be03 remain preserved. See docs/reports/authoring-integration-readiness.md.