Skip to content

Add guarded saved-block types with composed recovery and history fixes - #32

Merged
MrScripty merged 5 commits into
mainfrom
fix/integrate-saved-block-types
Oct 14, 2026
Merged

MrScripty merged 5 commits into
mainfrom
fix/integrate-saved-block-types

Conversation

@MrScripty

@MrScripty MrScripty commented Oct 14, 2026 •

Copy link
Copy Markdown
Owner

Saved screenplay Edit accepts text only. This extends the guarded edit with optional block kind, preserves exact type/text draft and immutable retry custody, and supplies owned original/current type evidence to targeted screenplay review. This is Stage B stacked on PR31, so its review delta adds block types once.

Exact head: 1b2672c; tree 895c33c44ae7a54224bd10033a37f2db2daa07bc. Merge7e138823 preserves product57b0d2ec and Stage A as parents; the additive plan conflict retains all admitted scopes. The final forward merge retains Stage A's bounded panic-test synchronization repair. Historical frozen qualifier/docs branches remain preserved; their obsolete pinned workflows are not imported.

Independent GPT-6.1 Sol High review found two composition defects and verified regressions failed before repair: missing-block copy discarded the edited type; manual creation duplicated block_kind history and broke keyed Change Review rendering. Copy now preserves/displays the authored draft kind, requires explicit creation Save and retains the original. The shared revision owns one kind delta and immutable replay history. Final exact-head review approves with no remaining P1/P2.

Local validation: 129 core and 621 server all-target tests, strict all-target/all-feature core/server Clippy, 113 files/641 UI tests, lint/format/typecheck (0 errors/warnings), static build, audit zero moderate/high/critical (three existing low cookie rows), and decision traceability. Tests use main's unchanged exact Pumas a94fd920 producer. Original PR29be03 is unchanged. Disposable compatibility at archive87a985c4 passed 129 core, 638 server and 646 UI tests plus strict Clippy/frontend gates; no compatibility ref was pushed. The final change since compatibility is test synchronization and evidence notes only.

Fresh CI105 passed all four jobs on this exact head: https://github.com/MrScripty/Eidetic/actions/runs/38653069004 . Linux and Windows each passed 995 Rust tests (two existing ignored); frontend passed 641 tests plus audit/lint/format/typecheck/static build, and decision traceability passed. The tested merge54eaa81b tree matches the independently reviewed 895c33c4 head tree. Both repaired composition regressions and the bounded panic test pass. The enabled local native pre-push attempt fails at absent GTK/WebKit development libraries; publication uses only the existing authorized unavailable-test exclusion with these compensating source gates. Current Chromium widget smoke aborted before page execution at a misconfigured enabled SUID sandbox; no sandbox was disabled. Compiled-client/SSR and actual public-service/SQLite tests are current evidence. Current browser/native interaction remains unqualified. Historical native reports and synthetic fixtures do not qualify current native interaction or trained models; PR29's trained-model gate remains intact.

Parent owns actual merges: merge PR31 first, retarget this PR to fresh main, verify the exact merge tree and required base-sensitive checks, then merge after reviewing limits. See docs/reports/authoring-integration-readiness.md.

@coderabbitai

coderabbitai Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration
  • Configuration used: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 1763cd74-f48a-4882-9429-56fe45c43fdd
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@MrScripty
MrScripty changed the base branch from fix/integrate-authoring-custody to main October 14, 2026 23:39
@MrScripty
MrScripty marked this pull request as ready for review October 14, 2026 23:40
@MrScripty
MrScripty merged commit 6bef187 into main Oct 14, 2026
5 checks passed
@MrScripty
MrScripty deleted the fix/integrate-saved-block-types branch October 14, 2026 23:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant