Repository navigation
Qualify protected CPU key reuse with a frozen native comparison - #91
Merged
Merged
Conversation
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
MrScripty
marked this pull request as ready for review
October 21, 2026 07:48
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The protected Rust host can explicitly select ordinary-member bounded key reuse. This PR qualifies that existing path through a prospectively frozen native CPU comparison and corrects the oracle's treatment of shared backend identity:
runtime.candleis legitimate, while each member retains separate task/attempt/request/reservation/grant custody and exact receipt matching.Merged normally; the finite ordinary-member key-reuse checklist is complete within its named scope. V2 passed once. V1 remains failed and unchanged.
Reviewed source
6adf0ca7010fc2ab1e8bbe3db30673f27a3856f9, tree62d486fa88acf887f2de4bdc3d1339b41d209b15, passed all 22 candidate checks and all five candidate workflows. Actual merge9ec7e7f3f4a0db1a1123bdc5504f76f4b79322f6preserves parentsecfed47da7c51d03b968bed739e2abc06eb4a6deand6adf0ca7010fc2ab1e8bbe3db30673f27a3856f9with the identical reviewed tree. All 20 actual-main checks and all four post-merge workflows succeeded:9ec7e7f3f4a0db1a1123bdc5504f76f4b79322f6.9ec7e7f3f4a0db1a1123bdc5504f76f4b79322f6.9ec7e7f3f4a0db1a1123bdc5504f76f4b79322f6.9ec7e7f3f4a0db1a1123bdc5504f76f4b79322f6.Independent review covered the full producer, corrected oracle, prospective protocol, supervisor, frozen manifest/binary, raw records, actual artifact bytes and retained archive, then reaffirmed the exact final source/tree for normal merge. There were no unresolved GitHub review threads at merge. This is agent source/evidence review; CodeRabbit's draft skip supplies no source approval.
The physical v2 cohort was frozen at source
1f6af8a25440d6a4049a3e86c86785689b71cf70, tree0368ee2e945976ec84930f3a779995b4cc6f473a, before its single bounded execution. Both fresh arms completed two native forwards with genuine two-Ready proposals, distinct member custody, exact cross-arm output equality, retained artifact readbacks with maximum absolute error 5.960464477539063e-8 against the frozen golden, fresh owners and all five phase observations. Baseline recorded 6 encodings / 0 hits; enabled recorded 4 encodings / 4 hits; both ended with 0 healthy retained entries. Public closes/shutdown were acknowledged, final reservations were empty, and no idle owner remained. The process exited 0, was reaped and did not time out. Producer and prospective protocol bytes were unchanged afterward.V2's 39-file retained archive is 131,938 bytes, SHA256
d7cd6334bcec3b2a72c9f4eee026b0a507d62f7388db9739e611d4c179b98828. It contains both raw arms, journal, actual artifacts, frozen inputs and preparation/review receipts; every original byte/hash was verified. V1's archive remains SHA256e6edef6c58518ab809be8fc5b31d1c9e18abd700ddafdb5037c82aa70fbed340. Both original exclusive execution markers remain retained; neither cohort was repeated or relabeled.The final actual-integration receipt is
pr91-integration-final-receipt.json, SHA25680926b66083f054bc1108d68e3154890d386cfe5fb820d4c922146f2031676c4, retained at/workspace/scratch/pantograph-recovery/. It records exact checks/runs, parents/tree, cohort hashes, all 9 clean retained worktrees, 13 protected source branch tips and unchanged PR84 lineage. This merged PR and the hashed receipt own terminal integration status; committed plan/checklist/report text is the publication-time checkpoint.Finite closure: INT-89 complete; M5-SW accepted within ordinary-member bounded key reuse; M6-SW complete through the explicit host constructor/configuration query; M5-CPU passed the narrow frozen v2 criteria; M6-CLOSE complete after exact-source review and candidate/actual-main CI. Stop implementation of this envelope here. No additional allocator or instrumentation slice is selected.
Local v2 validation passed: 10 model-free oracles; 617 default embedded tests with 2 existing ignored probes; strict own-package all-feature/all-target Clippy; warning-deny Rustdoc; formatting; traceability/local links; declared pre-push 261 passes / 1 existing ignore plus 168 passes. Baseline strict inference lint/Rustdoc limitations remain documented and unsuppressed.
This untrained two-member debug-build case establishes mechanism, correctness and ownership within the reported scope. It does not establish trained ranking, forecast accuracy, speedup, complete incremental memory or representative model/hardware behavior. Forecast history was cold; phase spans overlap and observer overhead is uncalibrated. Scheduler cleanup/private-proof matching is source-assisted; registry ACKs are separately observed. Conservative reservations are not physical allocation measurements.
Remaining representative qualification requires frozen model/tokenizer revisions, inputs/shapes, settings, baseline, target hardware/environment and an independently reviewed measurement protocol. Complete allocation-start/drop/alias/scratch/worker attribution is separate future software only for a separately admitted complete-memory claim. No current software input blocks the completed bounded envelope. Admission/defaults, allocator policy, dependencies, CI and bindings are unchanged. All prior commits, branches, PR84 and unrelated work are preserved; historical denied log routes were not retried.