Repository navigation
Refine desktop controls and add scene force authoring - #146
Merged
Merged
Conversation
added 8 commits
October 20, 2026 22:49
(cherry picked from commit 8bf5f41)
(cherry picked from commit cb06a14)
(cherry picked from commit 426fd25)
…dence (cherry picked from commit e1097581d751c061eaf8c2df45d83de62911a74d)
…tus UI (cherry picked from commit 7318023f04946171d7909119300af76e455c2926)
Preserve the original M2a working slice from prerequisite 7318023 without rewriting its evidence. The accidental broad-filter fixture execution and automatic output teardown are recorded as an incident, not scientific acceptance. Original patch SHA256 0c8b8d4e4eb87f761ff94f998f58548888ba23aa6b40414605652044816c2a6b; exact tree8740bf155b3db1f3c44e109277605b9411f459fe. (cherry picked from commit 1b5842968fcec2d83472ab1aada3c0ef30bb5d8c)
Focused numeric fields use round-trip text without changing unchanged canonical SI values. Preserve units, explicit-edit ranges and transactional ownership. Five individually enumerated and inspected exact UI-only tests passed; independent source review is included. UI-5 was observed after M2a; no untouched-baseline reproduction is claimed. Exact frozen precision tree3e1fd57146e2f1a02abe22a09ac317497f39d738. (cherry picked from commit 11415a5000dbd223bcdbfbd5afdd5b5465f60845)
Measure only the disabled invisible timeline projection using ordinary layout, keep the measurement accessibility subtree hidden and commit real interaction once. Replace growing speed DragValue editing with a bounded labelled field, finite validation and keyboard adjustment. Four exact inspected UI-only tests cover cold/warm bounds, focus-only precision, invalid editor stress, native track selection and synthetic report captions; strict Clippy, affected check and formatting pass. Idle strip is48px instead of106px at620/970px available widths. Native, configured long-caption and popup keyboard coverage remain open. (cherry picked from commit cbe08067820ef65cf75f18504805ed2c020865d4)
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configuration
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Use one ForceScene, checked shared model/force IDs and context-scoped selection for directional, radial and vortex authoring. Preserve validated SI properties, immutable retained geometry and playback index; narrow windows reuse the existing run/status owner. Refuse new authored-force runs and independent unsupported labs/AI entry points until runtime and archive integration exists. Fourteen individually inspected exact UI-only tests, locked check, strict Clippy and independent source/evidence review pass. Native rendering, viewport picking/outlines/handles and authored runtime remain explicit follow-up scope; no numerical or model workloads executed.
MrScripty
changed the title
MrScripty
changed the title
added 5 commits
October 20, 2026 23:47
MrScripty
changed the base branch from
implementation/shared-force-domain-20261020
to
main
October 21, 2026 00:46
added 9 commits
October 21, 2026 00:47
Preserve the merged backend review and historical inventories, append the reviewed UI scope, and explicitly bind all 136 selected source paths. This admits fresh qualification while production force execution remains Pending.
Resolve the two admission conflicts by preserving the complete merged backend review and the independently reviewed 136-path UI binding. The resulting tree is identical to 6153a02; runtime, UI, book and production gate bytes are unchanged.
MrScripty
marked this pull request as ready for review
October 21, 2026 06:54
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The desktop has a compact content-sized timeline and a collapsible right Scene panel with selection-driven properties. Directional, radial and vortex forces use canonical shared-domain objects, stable IDs and explicit units. Tree and viewport share selection, thin outlines and named Move/Rotate/Size handles; draft manipulations validate on release and cancel on Escape or context/focus loss.
Native-carrier and particle-material dispatch carry immutable track-specific force snapshots through canonical adapters and Inspector recording APIs. Saved native force intents use version2 while preserving exact version1 bytes/hashes and manifest version1. Retained properties are read-only and project the same render-frame track/document as the viewport. Production authored-force launches remain gated. One typed eligibility policy keeps production qualification Pending; configured/session/provider/free-surface/AI remain Unsupported even under test qualification.
Two separate native-findings repairs: d6e23b3 bounds narrow scaled timeline selectors/captions; 1b37774 snapshots keyboard focus before egui input acquires its context lock. The existing validator reports exact1b377742 hover/resize/Scene opening/normalclose exit0 and narrow synthetic timeline labels/popup/captions/DraftRetained restoration passed. Viewport picking/outline/handles/Escape/camera isolation remain pending. This owner has no display and claims no new native rendering, JPEG or Library delivery.
Two independently reviewed exact real-Worker/SQLite tests ran once each serially on sealed3b3fccea3657d711897130643a478adb48b5edd0, binary SHA af2da1539521e10407ac73b11cd58494118aa93a3f99ed529b11697ed85727b5. Each passed1, exit0. Native8cells/one requested1e-6s interval/max100pressure iterations; material64particles/one step/max16preparations. Both check dispatch-effect guards, immutable custody and coldreadback. Native final DATA5files39527bytes, material1file49152bytes. Applied30s deadline/20CPU/512MiBAS/1MiBper-file+log, no timeout/signals/survivor observed. Temporary SQLite peak unknown; final8file8MiB assertion is not an aggregate hardcap. Archive source strings are build-unspecified; external seals establish tested source custody.
Evidence-only e5e6cff preserves receipts/reviews; 9099b15 separately prepares still-gated policy. Five exact inspected pure cases, locked offline check, strict production Clippy, formatting and pinned structural plan check pass. Original stale-copy assertion and unused-accessor lint failures are retained with repairs. Runtime passes apply to3b, not automatic qualification of9099b15. Material has no serialized cold-rerun API; retained typed Request plus cold force association only. Native rerun clone is non-executable prepared intent; no second run. No interrupted Cancel, full parity or scientific acceptance follows.
Dependency: PR145 canonical core ancestor43ec505218c43594641ecbb80873bec8c88d7d2c. Fetched backend a4326a7 adds admission documents only, not copied/refreshed here. D1 comparison and worker/session ownership remain. Plans/ledger, exact seals, logs, independent reviews and contracts are under docs/plans/ui-refinement. DATA archives and used binary remain preserved in local scratch with byte/hash indexes. No merge, historical migration, numerical retuning or cleanup requested. Actual force-enabled UI launch, gestures, cancellation, broader accessibility/usability and full M1 acceptance remain open; enablement requires a separate reviewed candidate after native prerequisites.