Repository navigation
Conversation
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: true
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
Disposition (2026-10-21): closing as already integrated by PR114, merge The original exact-head run39400013651 remains failed at unittest step37; raw-log retrieval was denied by the redirected host and was stopped. Main's later automatic lifecycle, workspace UI and three extension/package workflows passed. This does not reclassify the original failure or establish scientific/model acceptance. Retargeting to main was attempted before parent disposition; GitHub refused with 422 because there are no new commits. Closing this fully integrated child before #112 leaves no open dependent. Branch and commits remain preserved. |
The access browser read DOM state immediately after navigation/reload acknowledgements, while the previous document could still be active. It now waits for a changed main loader and that loader's load event before either access journey proceeds. CDP requests and load waits are bounded, with phase/method diagnostics that omit command parameters. Shutdown awaits only supplied owned-child handles before bounded removal of the exact test profile. All 14 original assertions remain.
This PR depends on #112 at
0dedbc953902ac89389dca0693006aaa02a0a87c. Its exact head iscd77bc3d9f148a7c7b80a5cf19e974ed5285c0e2: three test files plus retained qualification evidence, with no product or workflow edits.Validation passed: three syntax checks; controlled old-order failure and corrected navigation/reload ordering; timeout/target-close/parameter-disclosure cases; existing page-load and owned-child regressions; and the complete default
node tests/browser_access.cjsjourney on existing PostgreSQL17.6, Python3.12.14, Node24.19.0 and Chromium151 (exit0,8.605350s). Independent review cleared source and actual receipts. The actual run records precommit HEAD0ded with dirty source; all three tested file hashes match this commit. Exact fixture schema/profile cleanup is recorded, with zero Runs and terminal supplied main handles; no unconditional descendant-shutdown guarantee is claimed.Original lifecycle 39370107550 remains failed at access step41: CDP
-32000: Inspected target navigated or closed, followed by secondary cleanupENOTEMPTY. Same-head sibling 39370108074 passed all173steps at unchanged0ded. Both outcomes are retained: they establish differing executions at the same checkout, not the original error's exact cause or a failure-rate estimate. That sibling did not execute this repair and does not qualify its hosted CI.Source-bound local logs, original failure excerpt/hash, screenshots and independent review are in
docs/plans/lab-workflow-reliability/reports/access-browser-ci-20261020/acceptance.md. Fresh exact-head hosted qualification remains required. PUB-1 original diagnostic evidence and SCI-1 owned criterion/compatible lab pair remain unresolved; no scientific, CUDA or model-quality acceptance is inferred.