Skip to content

Synchronize access browser navigation and owned shutdown - #113

Closed
MrScripty wants to merge 1 commit into
fix/captions-dialog-ci-qualification-20261020from
fix/access-browser-ci-qualification-20261020
Closed

MrScripty wants to merge 1 commit into
fix/captions-dialog-ci-qualification-20261020from
fix/access-browser-ci-qualification-20261020

Conversation

@MrScripty

Copy link
Copy Markdown
Owner

The access browser read DOM state immediately after navigation/reload acknowledgements, while the previous document could still be active. It now waits for a changed main loader and that loader's load event before either access journey proceeds. CDP requests and load waits are bounded, with phase/method diagnostics that omit command parameters. Shutdown awaits only supplied owned-child handles before bounded removal of the exact test profile. All 14 original assertions remain.

This PR depends on #112 at 0dedbc953902ac89389dca0693006aaa02a0a87c. Its exact head is cd77bc3d9f148a7c7b80a5cf19e974ed5285c0e2: three test files plus retained qualification evidence, with no product or workflow edits.

Validation passed: three syntax checks; controlled old-order failure and corrected navigation/reload ordering; timeout/target-close/parameter-disclosure cases; existing page-load and owned-child regressions; and the complete default node tests/browser_access.cjs journey on existing PostgreSQL17.6, Python3.12.14, Node24.19.0 and Chromium151 (exit0,8.605350s). Independent review cleared source and actual receipts. The actual run records precommit HEAD0ded with dirty source; all three tested file hashes match this commit. Exact fixture schema/profile cleanup is recorded, with zero Runs and terminal supplied main handles; no unconditional descendant-shutdown guarantee is claimed.

Original lifecycle 39370107550 remains failed at access step41: CDP -32000: Inspected target navigated or closed, followed by secondary cleanup ENOTEMPTY. Same-head sibling 39370108074 passed all173steps at unchanged0ded. Both outcomes are retained: they establish differing executions at the same checkout, not the original error's exact cause or a failure-rate estimate. That sibling did not execute this repair and does not qualify its hosted CI.

Source-bound local logs, original failure excerpt/hash, screenshots and independent review are in docs/plans/lab-workflow-reliability/reports/access-browser-ci-20261020/acceptance.md. Fresh exact-head hosted qualification remains required. PUB-1 original diagnostic evidence and SCI-1 owned criterion/compatible lab pair remain unresolved; no scientific, CUDA or model-quality acceptance is inferred.

@coderabbitai

coderabbitai Bot commented Oct 20, 2026

Copy link
Copy Markdown

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

  • Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Copy link
Copy Markdown
Owner Author

Disposition (2026-10-21): closing as already integrated by PR114, merge 360bbda950cc48ed3c3d9193539039b68e0ac8cb. Exact head cd77bc3d9f148a7c7b80a5cf19e974ed5285c0e2 is an ancestor of current main 133d53c0e2985a6559ba9cebd7d4a9f530051f06; all 17 changed paths, including original evidence, match main byte-for-byte. Independent GPT-6.1 Sol High disposition review cleared closure. Fresh local CDP, access-navigation, page-load and owned-child regressions passed.

The original exact-head run39400013651 remains failed at unittest step37; raw-log retrieval was denied by the redirected host and was stopped. Main's later automatic lifecycle, workspace UI and three extension/package workflows passed. This does not reclassify the original failure or establish scientific/model acceptance.

Retargeting to main was attempted before parent disposition; GitHub refused with 422 because there are no new commits. Closing this fully integrated child before #112 leaves no open dependent. Branch and commits remain preserved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant